-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(feedback): Replay breadcrumb for feedback events was incorrect #10536
fix(feedback): Replay breadcrumb for feedback events was incorrect #10536
Conversation
Does this need to go out before v8? I'm planning on a v7 patch release to get out a profiling fix, I can backport these changes onto it too. |
@AbhiPrasad yeah we could backport it, this is not super high priority though -- when are you aiming for the next release? |
Whenever #10534 can merge and pass CI, hopefully tomorrow |
Should I make a PR w/ |
Merge it into |
#10534 was merged in, whenever you merge this PR in I'll backport and make a v7 release. |
#10542 should fix the CI issues with profiling. |
🤔 |
We are creating a replay breadcrumb when user feedback was submitted, however, the it was not typed correctly, which the timestamp not being included in the proper location.
802cc3c
to
9e94314
Compare
…10536) We are creating a replay breadcrumb when user feedback was submitted, however, the it was not typed correctly, which the timestamp not being included in the proper location.
We are creating a replay breadcrumb when user feedback was submitted, however, the it was not typed correctly, which the timestamp not being included in the proper location.