-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Astro integration upload source map warning #9591
Comments
Hi @youngboy thanks for writing in! The "no release name" warning should be safe to ignore because source maps no longer need to be associated with a release. (although we should do something to omit the warning or carry over the release from the A couple of questions to debug this:
|
@Lms24 Hi, thank you for your prompt reply. I'm currently utilizing the Vercel adapter. During local builds, the process unexpectedly does not proceed to the sourcemap upload step. However, the Vercel build logs indicate that despite some warnings, the sourcemap file is recognized and successfully uploaded. The issue arises in associating it with the release. This can be verified on the dashboard page at "/settings/projects/vivace/source-maps/artifact-bundles/," as shown in this screenshot: Additionally, in the release details page at "/releases/vivace%400.0.1/?project=4506240691798016," a similar situation is evident, as depicted in this screenshot: |
@youngboy You're using Sentry SaaS, correct? If yes, can you share a URL to an issue that should have source maps? This would help us debug this better. As I said, source maps don't have to be associated to the correct release anymore. We decoupled source maps and releases a while ago. Also please let me know the answers to these two questions from my first reply:
|
the dir is in
for vercel plugin, sourcemaps are in two dir I'll try to reproduce it with a minimal repo later. |
@Lms24 here is the issue link https://gethsemane.sentry.io/issues/4650978367/?project=4506257853448192&query=is%3Aunresolved&referrer=issue-stream&statsPeriod=14d&stream_index=0 and repo https://github.com/youngboy/sentry-9591 hope this will help |
Thanks for the repro, I'll take a look!
Oh I see, this is indeed something we didn't cover yet. We always assumed there's one output directory and within that, sub directories for client and server (I guess that would make too much sense lol). I have a feeling that we generally need to provide a user-configurable option for specifying the output directory. While I generally like the adapter pattern that more fullstack frameworks seem to be embracing, this severely messes up file output configs as they all do their own thing... |
Another thing I forgot: If you're deploying to Edge, the server SDK is probably not going to work correctly. We still need to add Edge support for Astro (which is a big challenge we only tackled in NextJS with mixed results so far). |
…ntry#9668) Adds the `assets` option to the Astro integration source maps upload options. It behaves just like the `assets` option of the Vite plugin, taking a (array of) glob(s) and overriding the default values. This came up in getsentry#9591 and I think it makes sense to give users with more advanced/custom setups the ability to override our defaults.
Is there an existing issue for this?
How do you use Sentry?
Sentry Saas (sentry.io)
Which SDK are you using?
@sentry/astro
SDK Version
7.80.1
Framework Version
Astro 3.4.0
Link to Sentry event
No response
SDK Setup
Steps to Reproduce
error
Expected Result
can find source maps file in release detail
Actual Result
error message:
[sentry-vite-plugin] Warning: No release name provided. Will not inject release. Please set the
release.name
option to identify your release.The text was updated successfully, but these errors were encountered: