Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wire up console.warn/console.error to Raven.captureMessage #85

Closed
mattrobenolt opened this issue Mar 14, 2013 · 6 comments
Closed

Wire up console.warn/console.error to Raven.captureMessage #85

mattrobenolt opened this issue Mar 14, 2013 · 6 comments

Comments

@mattrobenolt
Copy link
Contributor

Explicitly monkey patch console.* as log levels.

@defunctzombie
Copy link
Contributor

No.

@acdha
Copy link
Contributor

acdha commented Mar 14, 2013

I'm -0 on this - seems like it'd be noisy and only helps developers who'd be in a position to do it the right way instead.

@mattrobenolt
Copy link
Contributor Author

@acdha , it would be behind a log level setting. So you'd say, Raven.config(..., {level: 'warn'}) so you can control how much noise you want.

@acdha
Copy link
Contributor

acdha commented Mar 14, 2013

I wouldn't object to you adding it but I do wonder whether it would just encourage people to send poorly crafted log messages rather than integrate logging correctly.

@bisrael
Copy link
Contributor

bisrael commented Mar 15, 2013

usually when you do a Raven.captureMessage or captureException, you could put a console.log there if you like, or write a small wrapper for yourself, would be like two lines of code for the developer.

Edit: Really the developer should be wrapping calls to Raven.capture* anyways, otherwise you're really coupling yourself to the Raven implementation.

@mattrobenolt
Copy link
Contributor Author

This is done with the console plugin.

billyvg added a commit that referenced this issue May 5, 2023
- fix: Fix some input masking (esp for radio buttons) (#85)
- fix: Unescaped `:` in CSS rule from Safari (#86)
- feat: Define custom elements (web components) (#87)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants