-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Next.js Turbopack Support #8105
Comments
We are also eager to add support here! We have 2 plugin repos to add support for webpack, esbuild, rollup, and vite. The latter 3 we support via an opensource project where we'd love to see support so we could potentially adopt it via our usage of their adapters. Upvote the issue there as well. Although I do not think it is on their immediate radar either. unjs/unplugin#302 https://github.com/getsentry/sentry-webpack-plugin https://github.com/getsentry/sentry-javascript-bundler-plugins |
any news on this? |
@mdugue We'll tackle turbopack when it becomes somewhat stable. |
Fwiw I would also encourage you to upvote and comment on this issue which wr could also use to provide support similar to webpack, vite, esbuild and rollup |
UpdateAs of now, we cannot transfer the functionality we currently have in the SDK to Turbopack: Turbopack loaders are not passed transpiled javascript, instead, they are passed the original user code. The SDK needs transpiled JS to properly be able to do transformations to modules. We could transpile the user code ourselves but that is fragile AF - so not an option. As of now, the SDK will continue to work in production mode which is arguably more important, but we would like to support dev mode. Branch with my experiments: #9295 |
To clarify, does it work with Turbopack in production mode as-is or only with the changes in your branch? |
@Stanzilla Turbopack will not work with the SDK (dev and prod). My branch does not contain any fixes or features, just experiments proving that things don't work. |
It's also worth noting that the initial Turbopack support is for |
It become stable now at the beginning of the month. Would love to integrate it with sentry now :-) |
@guhur We are actively working on it. Tubopack may be stable but it still doesn't support a lot of features the SDK needs. You can use turbopack at any time with Sentry. Sentry just won't work well in dev mode. Turbopack for prod builds is still not stable. |
This PR is in preparation for turbopack (#8105). In the future, `sentry.client.config.ts` will likely need to be configured with a `"use client"` directive so that turbopack knows it needs to be treated as a file on the client. Our value injection loader currently always prepends the `sentry.client.config.ts` file with statements, rendering any directives in the file useless and crashing turbopack when the file is attempted to be imported somewhere. This PR detects any comments and directives on top of a file to only inject values after.
Hello, i got an error while running just pnpm dev --turbo on Next.js 15 with Sentry. This is the error:
I did EDIT: |
@TheCukitoDev I have fixed this issue by adding |
@spyl94 @TheCukitoDev please don't externalize the SDK. That will break it in all kinds of ways potentially. Instead add an override for your package manager to only have one |
It is my mistake sorry. I added require-in-the-middle instead of import-in-the-middle but I thought it was what it tells me the error to. |
Again Sorry. I made a mistake. When using react 18 it needs to use import-in-the-middle but when using the actual RC of React that next supports it needs require-in-the-middle so it is the confussion. Sorry again but I think now is clear and anyone with the same issue can solve it. |
…4081) Ref: #8105 To inject build-time variables, in addition to doing so via a custom loader, we will be injecting them via the `env` option. Caveat: We are currently using the Next.js build ID as a release name. This build id is passed to the `webpack` option. Since the `webpack` option doesn't exist for turbopack we don't have access to the build ID. For now we will simply not inject a release name, which may be better anyhow since turbopack is currently only stable for dev.
Important
This issue is tracking progress on Turbopack Support. If you find bugs or problems with the Sentry SDK in combination with Turbopack please open a separate issue. Thank you!
Problem Statement
Sentry should work in combination with Turbopack with all of its features.
Current Status (Last Update Nov 6, 2024)
onBuildEnd
hook implemented in Next.js- Needs way to inject debug IDs into bundles implemented in Next.js
The text was updated successfully, but these errors were encountered: