Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate sentry-replay into sentry-javascript #6257

Closed
9 tasks done
Tracked by #5326
mydea opened this issue Nov 22, 2022 · 0 comments · Fixed by #6270
Closed
9 tasks done
Tracked by #5326

Migrate sentry-replay into sentry-javascript #6257

mydea opened this issue Nov 22, 2022 · 0 comments · Fixed by #6270
Assignees

Comments

@mydea
Copy link
Member

mydea commented Nov 22, 2022

We want to migrate https://github.com/getsentry/sentry-replay into this monorepo, as packages/replay.

  • Ensure we keep Git branch history: https://blog.brunogarcia.com/2020/09/move-repositories-on-github-without.html
    • Ensure to run this on main of a fresh clone of the repo (doesn't work properly otherwise)
  • Merge into monorepo - see e.g. https://blog.jdriven.com/2021/04/how-to-merge-multiple-git-repositories/
    • Create branch monorepo-merge off sentry-replay master
    • Move all files there into a packages/replay folder using git mv -k * packages/sentry-replay (make sure target dir exists)
    • Delete unneeded root-level files (e.g. .gitignore, ...) - make sure nothing important is lost there
    • Merge the monorepo-merge branch from sentry-replay into sentry-javascript, like this:
    cd ../MonoRepo (1)
    git remote add -f RepoA ../RepoA (2)
    git merge -m "Integrating RepoA" RepoA/prepare_monorepo --allow-unrelated-histories (3)
    git remote rm RepoA (4)
    
  • Ensure existing tests run
  • Ensure package is excluded from publishing etc.
@mydea mydea assigned mydea and Lms24 Nov 22, 2022
Lms24 added a commit that referenced this issue Nov 24, 2022
Migrate the whole session replay code from https://github.com/getsentry/sentry-replay into the monorepo.

Note:

* Build, lint and tests work, but will need adjustments
* It is excluded from releasing in craft
* Some eslint rules etc. need to be fixed in later steps

Ref: #6257
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants