fix: Prevent fetch errors loops with invalid fetch implementations #3318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamilogorek
force-pushed
the
fetch-loop-two
branch
3 times, most recently
from
c88d351 to
a0b2f8c
Compare
size-limit report
|
kamilogorek
force-pushed
the
fetch-loop-two
branch
from
a0b2f8c to
69e96ba
Compare
mitsuhiko
approved these changes
Mar 10, 2021
This was referenced Mar 11, 2021
This was referenced Mar 15, 2021
Closed
sod
reviewed
Mar 19, 2021
Comment on lines
+54
to
+60
| const sandbox = document.createElement('iframe'); | ||
| sandbox.hidden = true; | ||
| document.head.appendChild(sandbox); | ||
| if (sandbox.contentWindow?.fetch) { | ||
| return sandbox.contentWindow.fetch.bind(global); | ||
| } | ||
| document.head.removeChild(sandbox); |
There was a problem hiding this comment.
This is so slow, that it doesn't execute below 50ms for mobile lighthouse. Thus it delays the TTI metric plus adds to TBT in lighthouse, even if you only execute install in a single macrotask, thus including sentry now costs you points in mobile lighthouse and lowers your ranking on google.
desktop
mobile
There was a problem hiding this comment.
This was 6.0.1 btw., so quite some regression
There was a problem hiding this comment.
Thanks for letting us know, should be patched in #3341
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.