Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@sentry/browser leaving iframe in head #3342

Closed
4 of 8 tasks
MattCrouch opened this issue Mar 22, 2021 · 2 comments
Closed
4 of 8 tasks

@sentry/browser leaving iframe in head #3342

MattCrouch opened this issue Mar 22, 2021 · 2 comments

Comments

@MattCrouch
Copy link

MattCrouch commented Mar 22, 2021 •
edited
Loading

Package + Version

  • @sentry/browser
  • @sentry/node
  • raven-js
  • raven-node (raven for node)
  • other:

Version:

6.2.3

Description

Since 6.2.2 we have been seeing an empty <iframe> in the <head> section of our HTML. I believe it's as a result of changes in #3318.

We have various automated tests running in our staging environment that check over built code. While the <iframe> itself doesn't cause any runtime issues, it is causing our accessibility tests to fail as it's picking up an inaccessible element.

I would guess it's not supposed to be staying around?
@kamilogorek
Copy link
Contributor

Thanks for the report. Fixed in #3341 as well as added fast path for better performance.

@kamilogorek
Copy link
Contributor

Fixed in 6.2.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kamilogorek @MattCrouch