Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: Can't resolve 'domain' in @sentry/hub/dist #1670

Closed
4 of 8 tasks
samalexander opened this issue Oct 23, 2018 · 17 comments
Closed
4 of 8 tasks

Error: Can't resolve 'domain' in @sentry/hub/dist #1670

samalexander opened this issue Oct 23, 2018 · 17 comments
Assignees

Comments

@samalexander
Copy link

Package + Version

  • @sentry/browser
  • @sentry/node
  • raven-js
  • raven-node (raven for node)
  • other:

Version:

4.2.0

Description

Building an Angular project with @sentry/browser v4.2.0 produces the error:

ERROR in ./node_modules/@sentry/hub/dist/hub.js
Module not found: Error: Can't resolve 'domain' in 'node_modules/@sentry/hub/dist'
@HazAT
Copy link
Member

HazAT commented Oct 23, 2018

Thx for reporting this, fix will soon be released.

@HazAT HazAT self-assigned this Oct 23, 2018
@HazAT
Copy link
Member

HazAT commented Oct 23, 2018

Fixed in 4.2.1

@bsbechtel
Copy link

I have 4.2.1 installed and am still seeing this issue. I just upgraded to Angular 7.

@lbracken
Copy link

Also seeing issue, but as a warning, with @sentry/browser 4.2.1 and Angular 7.0.0

WARNING in ./node_modules/@sentry/hub/dist/hub.js
Module not found: Error: Can't resolve 'domain' in '/<project-dir>/node_modules/@sentry/hub/dist'

@HazAT
Copy link
Member

HazAT commented Oct 24, 2018

Can I ask you guys what kind of packager are you using?

@HazAT HazAT reopened this Oct 24, 2018
@samalexander
Copy link
Author

@HazAT we are using the angular-cli

@ddikman
Copy link

ddikman commented Oct 24, 2018

Same here with:

angular-cli 7.0.2
npm 6.4.1
node 10.9.0

Output on ng serve

WARNING in ./node_modules/@sentry/hub/dist/hub.js
Module not found: Error: Can't resolve 'domain' in '/my-app-proto/node_modules/@sentry/hub/dist'

Doesn't seem to stop any functionality, errors are beings sent correctly.

@HazAT
Copy link
Member

HazAT commented Oct 24, 2018

Yeah, I am currently digging into this, webpack outputs this warning, our SDK works.
I am looking for workaround that webpack doesn't spit out this warning.

@HazAT
Copy link
Member

HazAT commented Oct 24, 2018

OK, I've found a workaround:
9cf2c4b#diff-f42b1df1354d117face937b0ba20beb0

This should fix it, releasing a fix soon.

@Prtkpwr
Copy link

Prtkpwr commented Oct 24, 2018

please release an update soon.. i cant wait to use this in my application

@HazAT
Copy link
Member

HazAT commented Oct 24, 2018

@Prtkpwr You should be able to use it right now anyway, it's "just" a warning.
We are still testing stuff to make sure we do not regress.

@EyePulp
Copy link

EyePulp commented Oct 24, 2018

Confirming we're seeing this in a Vue CLI 3 project with webpack 4. Just a warning, seems functional otherwise.

Thanks for jumping on this @HazAT

@Prtkpwr
Copy link

Prtkpwr commented Oct 25, 2018 via email

@HazAT
Copy link
Member

HazAT commented Oct 25, 2018

4.2.2 is on it's way now

@Prtkpwr
Copy link

Prtkpwr commented Oct 25, 2018 via email

@ddikman
Copy link

ddikman commented Oct 25, 2018

Perfect, cheers!
I can confirm I'm no longer seeing this on:

angular-cli 7.0.2
npm 6.4.1
node 10.9.0
@sentry/browser 4.2.3

@EyePulp
Copy link

EyePulp commented Oct 25, 2018

No more warning under Vue. Nice work - cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants