Skip to content

Commit

Permalink
ci: fix ember flaky test (#3718)
Browse files Browse the repository at this point in the history
* Fix CI ember flaky test
  • Loading branch information
ahmedetefy authored Jun 21, 2021
1 parent 8b28573 commit f6ac741
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions packages/ember/tests/acceptance/sentry-performance-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,13 @@ function assertSentryCall(assert, callNumber, options) {
return `${s.op} | ${normalizedDescription}`;
});

// FIXME: For some reason, the last `destroy` run queue event is not always called.
// FIXME: For some reason, the last `afterRender` and `destroy` run queue event are not always called.
// This is not a blocker, but should be investigated and fixed, as this is the expected output.
if (event.spans[event.spans.length - 1] !== 'ember.runloop.destroy | undefined') {
const lastSpan = event.spans[event.spans.length - 1];
if (lastSpan === 'ember.runloop.afterRender | undefined') {
event.spans.push('ember.runloop.destroy | undefined');
} else if (lastSpan === 'ember.runloop.render | undefined') {
event.spans.push('ember.runloop.afterRender | undefined', 'ember.runloop.destroy | undefined');
}

assert.deepEqual(event.spans, options.spans, `Has correct spans`);
Expand Down

0 comments on commit f6ac741

Please sign in to comment.