Skip to content

Commit

Permalink
Fixed incorrect span check
Browse files Browse the repository at this point in the history
  • Loading branch information
ahmedetefy committed Jun 21, 2021
1 parent d81ba39 commit e53a66a
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions packages/ember/tests/acceptance/sentry-performance-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,11 @@ function assertSentryCall(assert, callNumber, options) {

// FIXME: For some reason, the last `afterRender` and `destroy` run queue event are not always called.
// This is not a blocker, but should be investigated and fixed, as this is the expected output.
if (event.spans[event.spans.length - 1] !== 'ember.runloop.afterRender | undefined') {
event.spans.push('ember.runloop.afterRender | undefined');
}
if (event.spans[event.spans.length - 1] !== 'ember.runloop.destroy | undefined') {
const lastSpan = event.spans[event.spans.length - 1];
if (lastSpan === 'ember.runloop.afterRender | undefined') {
event.spans.push('ember.runloop.destroy | undefined');
} else if (lastSpan === 'ember.runloop.render | undefined') {
event.spans.push('ember.runloop.afterRender | undefined', 'ember.runloop.destroy | undefined');
}

assert.deepEqual(event.spans, options.spans, `Has correct spans`);
Expand Down

0 comments on commit e53a66a

Please sign in to comment.