Skip to content

Commit

Permalink
fix(aws-serverless): Remove v8 layer as it overwrites the current lay…
Browse files Browse the repository at this point in the history
…er for docs (#14679)

Unfortunately, having the v8 layer already in `.craft.yml` ends up with
this layer being the default selection in the docs.

![Screenshot 2024-12-12 at 13 02
08@2x](https://github.com/user-attachments/assets/30bb83ce-79e9-41b1-887b-ec4ab7019a10)

We should add this to the `v8` branch once it exists instead.
  • Loading branch information
andreiborza authored Dec 12, 2024
1 parent 938fe65 commit d9d3b06
Showing 1 changed file with 5 additions and 6 deletions.
11 changes: 5 additions & 6 deletions .craft.yml
Original file line number Diff line number Diff line change
Expand Up @@ -142,10 +142,12 @@ targets:
id: '@sentry-internal/eslint-config-sdk'
includeNames: /^sentry-internal-eslint-config-sdk-\d.*\.tgz$/

# AWS Lambda Layer target
# TODO(v9): Remove this target
# NOTE: We publish the v8 layer under its own name so people on v8 can still get patches
# whenever we release a new v8 version—otherwise we would overwrite the current major lambda layer.
- name: aws-lambda-layer
includeNames: /^sentry-node-serverless-\d+.\d+.\d+(-(beta|alpha|rc)\.\d+)?\.zip$/
layerName: SentryNodeServerlessSDK
layerName: SentryNodeServerlessSDKv8
compatibleRuntimes:
- name: node
versions:
Expand All @@ -157,13 +159,10 @@ targets:
- nodejs20.x
license: MIT

# NOTE: We publish the v8 layer under its own name so people on v8 can still get patches
# whenever we release a new v8 version—otherwise we would overwrite the current major lambda layer.

# AWS Lambda Layer target
- name: aws-lambda-layer
includeNames: /^sentry-node-serverless-\d+.\d+.\d+(-(beta|alpha|rc)\.\d+)?\.zip$/
layerName: SentryNodeServerlessSDKv8
layerName: SentryNodeServerlessSDK
compatibleRuntimes:
- name: node
versions:
Expand Down

0 comments on commit d9d3b06

Please sign in to comment.