feat(v8): Remove span.toTraceparent method (#10698)

ref #10677
getsentry · Feb 21, 2024 · c4acfe9 · c4acfe9
1 parent 743c6c4
commit c4acfe9
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 27 deletions.
diff --git a/dev-packages/e2e-tests/test-applications/debug-id-sourcemaps/package.json b/dev-packages/e2e-tests/test-applications/debug-id-sourcemaps/package.json
@@ -15,7 +15,7 @@
   "devDependencies": {
     "rollup": "^4.0.2",
     "vitest": "^0.34.6",
-    "@sentry/rollup-plugin": "2.8.0"
+    "@sentry/rollup-plugin": "2.14.2"
   },
   "pnpm": {
     "overrides": {

diff --git a/packages/core/src/tracing/sentrySpan.ts b/packages/core/src/tracing/sentrySpan.ts
@@ -24,7 +24,6 @@ import {
   spanTimeInputToSeconds,
   spanToJSON,
   spanToTraceContext,
-  spanToTraceHeader,
 } from '../utils/spanUtils';
 import type { SpanStatusType } from './spanstatus';
 import { setHttpStatus } from './spanstatus';
@@ -454,15 +453,6 @@ export class SentrySpan implements SpanInterface {
     this._endTime = spanTimeInputToSeconds(endTimestamp);
   }
 
-  /**
-   * @inheritDoc
-   *
-   * @deprecated Use `spanToTraceHeader()` instead.
-   */
-  public toTraceparent(): string {
-    return spanToTraceHeader(this);
-  }
-
   /**
    * @inheritDoc
    *

diff --git a/packages/tracing/test/span.test.ts b/packages/tracing/test/span.test.ts
@@ -14,7 +14,7 @@ import {
 } from '@sentry/core';
 import type { BaseTransportOptions, ClientOptions } from '@sentry/types';
 
-import { TRACEPARENT_REGEXP, Transaction } from '../src';
+import { Transaction } from '../src';
 import { getDefaultBrowserClientOptions } from './testutils';
 
 describe('SentrySpan', () => {
@@ -125,15 +125,6 @@ describe('SentrySpan', () => {
     });
   });
 
-  describe('toTraceparent', () => {
-    test('simple', () => {
-      expect(new SentrySpan().toTraceparent()).toMatch(TRACEPARENT_REGEXP);
-    });
-    test('with sample', () => {
-      expect(new SentrySpan({ sampled: true }).toTraceparent()).toMatch(TRACEPARENT_REGEXP);
-    });
-  });
-
   describe('toJSON', () => {
     test('simple', () => {
       const span = JSON.parse(

diff --git a/packages/types/src/span.ts b/packages/types/src/span.ts
@@ -330,12 +330,6 @@ export interface Span extends Omit<SpanContext, 'name' | 'op' | 'status' | 'orig
    */
   startChild(spanContext?: Pick<SpanContext, Exclude<keyof SpanContext, 'sampled' | 'traceId' | 'parentSpanId'>>): Span;
 
-  /**
-   * Return a traceparent compatible header string.
-   * @deprecated Use `spanToTraceHeader()` instead.
-   */
-  toTraceparent(): string;
-
   /**
    * Returns the current span properties as a `SpanContext`.
    * @deprecated Use `toJSON()` or access the fields directly instead.