Skip to content

Commit

Permalink
fix: Make Vue tracing options optional (#2897)
Browse files Browse the repository at this point in the history
* fix: Make Vue tracing options optional
  • Loading branch information
hadalin authored Sep 15, 2020
1 parent aca5a69 commit 77743be
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions packages/integrations/src/vue.ts
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,9 @@ export class Vue implements Integration {
/**
* @inheritDoc
*/
public constructor(options: Partial<IntegrationOptions>) {
public constructor(
options: Partial<Omit<IntegrationOptions, 'tracingOptions'> & { tracingOptions: Partial<TracingOptions> }>,
) {
this._options = {
// eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
Vue: getGlobalObject<any>().Vue,
Expand Down Expand Up @@ -313,7 +315,7 @@ export class Vue implements Integration {
}
};

// Each compomnent has it's own scope, so all activities are only related to one of them
// Each component has it's own scope, so all activities are only related to one of them
this._options.tracingOptions.hooks.forEach(operation => {
// Retrieve corresponding hooks from Vue lifecycle.
// eg. mount => ['beforeMount', 'mounted']
Expand Down

0 comments on commit 77743be

Please sign in to comment.