fix tests

getsentry · Jul 8, 2022 · 4eefcdf · 4eefcdf
1 parent 19d72d5
commit 4eefcdf
Show file tree

Hide file tree

Showing 5 changed files with 53 additions and 0 deletions.
diff --git a/packages/nextjs/test/integration/test/server/tracing200.js b/packages/nextjs/test/integration/test/server/tracing200.js
@@ -16,6 +16,9 @@ module.exports = async ({ url: urlBase, argv }) => {
         },
       },
       transaction: 'GET /api/users',
+      transaction_info: {
+        source: 'route',
+      },
       type: 'transaction',
       request: {
         url,

diff --git a/packages/nextjs/test/integration/test/server/tracing500.js b/packages/nextjs/test/integration/test/server/tracing500.js
@@ -15,6 +15,9 @@ module.exports = async ({ url: urlBase, argv }) => {
         },
       },
       transaction: 'GET /api/broken',
+      transaction_info: {
+        source: 'route',
+      },
       type: 'transaction',
       request: {
         url,

diff --git a/packages/nextjs/test/integration/test/server/tracingHttp.js b/packages/nextjs/test/integration/test/server/tracingHttp.js
@@ -29,6 +29,9 @@ module.exports = async ({ url: urlBase, argv }) => {
         },
       ],
       transaction: 'GET /api/http',
+      transaction_info: {
+        source: 'route',
+      },
       type: 'transaction',
       request: {
         url,

diff --git a/packages/nextjs/test/performance/client.test.ts b/packages/nextjs/test/performance/client.test.ts
@@ -45,6 +45,9 @@ describe('client', () => {
         tags: {
           'routing.instrumentation': 'next-router',
         },
+        metadata: {
+          source: 'route',
+        },
       });
     });
 
@@ -68,6 +71,9 @@ describe('client', () => {
               method: 'pushState',
               'routing.instrumentation': 'next-router',
             },
+            metadata: {
+              source: 'route',
+            },
           },
         ],
         [
@@ -81,6 +87,9 @@ describe('client', () => {
               method: 'replaceState',
               'routing.instrumentation': 'next-router',
             },
+            metadata: {
+              source: 'route',
+            },
           },
         ],
         [
@@ -94,6 +103,9 @@ describe('client', () => {
               method: 'pushState',
               'routing.instrumentation': 'next-router',
             },
+            metadata: {
+              source: 'route',
+            },
           },
         ],
       ];
@@ -120,6 +132,9 @@ describe('client', () => {
         name: '/login',
         op: 'navigation',
         tags: { from: '/[user]/posts/[id]', method: 'pushState', 'routing.instrumentation': 'next-router' },
+        metadata: {
+          source: 'route',
+        },
       });
 
       Router.router?.changeState('pushState', '/login', '/login', {});
@@ -131,6 +146,9 @@ describe('client', () => {
         name: '/posts/[id]',
         op: 'navigation',
         tags: { from: '/login', method: 'pushState', 'routing.instrumentation': 'next-router' },
+        metadata: {
+          source: 'route',
+        },
       });
     });
   });

diff --git a/packages/nextjs/test/utils/withSentry.test.ts b/packages/nextjs/test/utils/withSentry.test.ts
@@ -1,4 +1,6 @@
+import * as hub from '@sentry/hub';
 import * as Sentry from '@sentry/node';
+import { Client, ClientOptions } from '@sentry/types';
 import * as utils from '@sentry/utils';
 import { NextApiHandler, NextApiRequest, NextApiResponse } from 'next';
 
@@ -43,6 +45,7 @@ const flushSpy = jest.spyOn(Sentry, 'flush').mockImplementation(async () => {
   await sleep(FLUSH_DURATION);
   return true;
 });
+const startTransactionSpy = jest.spyOn(Sentry, 'startTransaction');
 
 describe('withSentry', () => {
   let req: NextApiRequest, res: NextApiResponse;
@@ -99,4 +102,27 @@ describe('withSentry', () => {
       expect(loggerSpy).toHaveBeenCalledWith('Done flushing events');
     });
   });
+
+  describe('tracing', () => {
+    it('starts a transaction when tracing is enabled', async () => {
+      jest
+        .spyOn(hub.Hub.prototype, 'getClient')
+        .mockReturnValueOnce({ getOptions: () => ({ tracesSampleRate: 1 } as ClientOptions) } as Client);
+
+      await callWrappedHandler(wrappedHandlerNoError, req, res);
+
+      expect(startTransactionSpy).toHaveBeenCalledWith(
+        {
+          name: 'GET http://dogs.are.great',
+          op: 'http.server',
+
+          metadata: {
+            baggage: expect.any(Array),
+            source: 'route',
+          },
+        },
+        { request: { url: 'http://dogs.are.great' } },
+      );
+    });
+  });
 });