ref(build): Turn on isolatedModules TS option (#4497)

getsentry · Feb 4, 2022 · 4e89e5c · 4e89e5c
1 parent ab2c8c6
commit 4e89e5c
Show file tree

Hide file tree

Showing 24 changed files with 107 additions and 94 deletions.
diff --git a/packages/angular/src/index.ts b/packages/angular/src/index.ts
@@ -1,7 +1,9 @@
+export type { ErrorHandlerOptions } from './errorhandler';
+
 export * from '@sentry/browser';
 
 export { init } from './sdk';
-export { createErrorHandler, ErrorHandlerOptions, SentryErrorHandler } from './errorhandler';
+export { createErrorHandler, SentryErrorHandler } from './errorhandler';
 export {
   getActiveTransaction,
   // TODO `instrumentAngularRouting` is just an alias for `routingInstrumentation`; deprecate the latter at some point

diff --git a/packages/browser/src/backend.ts b/packages/browser/src/backend.ts
@@ -45,7 +45,7 @@ export class BrowserBackend extends BaseBackend<BrowserOptions> {
   /**
    * @inheritDoc
    */
-  public eventFromMessage(message: string, level: Severity = Severity.Info, hint?: EventHint): PromiseLike<Event> {
+  public eventFromMessage(message: string, level: Severity = 'info' as Severity, hint?: EventHint): PromiseLike<Event> {
     return eventFromMessage(this._options, message, level, hint);
   }
 

diff --git a/packages/browser/src/eventbuilder.ts b/packages/browser/src/eventbuilder.ts
@@ -24,7 +24,7 @@ export function eventFromException(options: Options, exception: unknown, hint?:
     attachStacktrace: options.attachStacktrace,
   });
   addExceptionMechanism(event); // defaults to { type: 'generic', handled: true }
-  event.level = Severity.Error;
+  event.level = 'error' as Severity;
   if (hint && hint.event_id) {
     event.event_id = hint.event_id;
   }
@@ -38,7 +38,7 @@ export function eventFromException(options: Options, exception: unknown, hint?:
 export function eventFromMessage(
   options: Options,
   message: string,
-  level: Severity = Severity.Info,
+  level: Severity = 'info' as Severity,
   hint?: EventHint,
 ): PromiseLike<Event> {
   const syntheticException = (hint && hint.syntheticException) || undefined;

diff --git a/packages/browser/src/exports.ts b/packages/browser/src/exports.ts
@@ -1,4 +1,4 @@
-export {
+export type {
   Breadcrumb,
   BreadcrumbHint,
   Request,
@@ -15,7 +15,10 @@ export {
   User,
 } from '@sentry/types';
 
-export { SeverityLevel } from '@sentry/utils';
+export type { SeverityLevel } from '@sentry/utils';
+
+export type { BrowserOptions } from './backend';
+export type { ReportDialogOptions } from './helpers';
 
 export {
   addGlobalEventProcessor,
@@ -40,9 +43,8 @@ export {
   withScope,
 } from '@sentry/core';
 
-export { BrowserOptions } from './backend';
 export { BrowserClient } from './client';
-export { injectReportDialog, ReportDialogOptions } from './helpers';
+export { injectReportDialog } from './helpers';
 export { eventFromException, eventFromMessage } from './eventbuilder';
 export { defaultIntegrations, forceLoad, init, lastEventId, onLoad, showReportDialog, flush, close, wrap } from './sdk';
 export { SDK_NAME } from './version';
diff --git a/packages/browser/src/integrations/breadcrumbs.ts b/packages/browser/src/integrations/breadcrumbs.ts
@@ -230,7 +230,7 @@ function _fetchBreadcrumb(handlerData: { [key: string]: any }): void {
       {
         category: 'fetch',
         data: handlerData.fetchData,
-        level: Severity.Error,
+        level: 'error' as Severity,
         type: 'http',
       },
       {

diff --git a/packages/browser/src/integrations/globalhandlers.ts b/packages/browser/src/integrations/globalhandlers.ts
@@ -101,7 +101,7 @@ function _installGlobalOnErrorHandler(): void {
               column,
             );
 
-      event.level = Severity.Error;
+      event.level = 'error' as Severity;
 
       addMechanismAndCapture(hub, error, event, 'onerror');
     },
@@ -150,7 +150,7 @@ function _installGlobalOnUnhandledRejectionHandler(): void {
             isRejection: true,
           });
 
-      event.level = Severity.Error;
+      event.level = 'error' as Severity;
 
       addMechanismAndCapture(hub, error, event, 'onunhandledrejection');
       return;

diff --git a/packages/core/src/index.ts b/packages/core/src/index.ts
@@ -1,3 +1,7 @@
+export type { APIDetails } from './api';
+export type { BackendClass } from './basebackend';
+export type { ClientClass } from './sdk';
+
 export {
   addBreadcrumb,
   captureException,
@@ -17,17 +21,16 @@ export { addGlobalEventProcessor, getCurrentHub, getHubFromCarrier, Hub, makeMai
 export {
   // eslint-disable-next-line deprecation/deprecation
   API,
-  APIDetails,
   getEnvelopeEndpointWithUrlEncodedAuth,
   getStoreEndpointWithUrlEncodedAuth,
   getRequestHeaders,
   initAPIDetails,
   getReportDialogEndpoint,
 } from './api';
 export { BaseClient } from './baseclient';
-export { BackendClass, BaseBackend } from './basebackend';
+export { BaseBackend } from './basebackend';
 export { eventToSentryRequest, sessionToSentryRequest } from './request';
-export { initAndBind, ClientClass } from './sdk';
+export { initAndBind } from './sdk';
 export { NoopTransport } from './transports/noop';
 export { SDK_VERSION } from './version';
 

diff --git a/packages/core/test/mocks/backend.ts b/packages/core/test/mocks/backend.ts
@@ -38,7 +38,7 @@ export class TestBackend extends BaseBackend<TestOptions> {
     });
   }
 
-  public eventFromMessage(message: string, level: Severity = Severity.Info): PromiseLike<Event> {
+  public eventFromMessage(message: string, level: Severity = 'info' as Severity): PromiseLike<Event> {
     return resolvedSyncPromise({ message, level });
   }
 

diff --git a/packages/hub/src/index.ts b/packages/hub/src/index.ts
@@ -1,3 +1,10 @@
+export type {
+  Carrier,
+  // eslint-disable-next-line deprecation/deprecation
+  DomainAsCarrier,
+  Layer,
+} from './hub';
+
 export { addGlobalEventProcessor, Scope } from './scope';
 export { Session } from './session';
 export { SessionFlusher } from './sessionflusher';
@@ -10,8 +17,4 @@ export {
   Hub,
   makeMain,
   setHubOnCarrier,
-  Carrier,
-  // eslint-disable-next-line deprecation/deprecation
-  DomainAsCarrier,
-  Layer,
 } from './hub';
diff --git a/packages/hub/test/scope.test.ts b/packages/hub/test/scope.test.ts
@@ -85,8 +85,8 @@ describe('Scope', () => {
 
     test('setLevel', () => {
       const scope = new Scope();
-      scope.setLevel(Severity.Critical);
-      expect((scope as any)._level).toEqual(Severity.Critical);
+      scope.setLevel('critical' as Severity);
+      expect((scope as any)._level).toEqual('critical' as Severity);
     });
 
     test('setTransactionName', () => {
@@ -137,8 +137,8 @@ describe('Scope', () => {
 
     test('chaining', () => {
       const scope = new Scope();
-      scope.setLevel(Severity.Critical).setUser({ id: '1' });
-      expect((scope as any)._level).toEqual(Severity.Critical);
+      scope.setLevel('critical' as Severity).setUser({ id: '1' });
+      expect((scope as any)._level).toEqual('critical' as Severity);
       expect((scope as any)._user).toEqual({ id: '1' });
     });
   });
@@ -202,7 +202,7 @@ describe('Scope', () => {
       scope.setTag('a', 'b');
       scope.setUser({ id: '1' });
       scope.setFingerprint(['abcd']);
-      scope.setLevel(Severity.Warning);
+      scope.setLevel('warning' as Severity);
       scope.setTransactionName('/abc');
       scope.addBreadcrumb({ message: 'test' });
       scope.setContext('os', { id: '1' });
@@ -294,11 +294,11 @@ describe('Scope', () => {
     test('scope level should have priority over event level', () => {
       expect.assertions(1);
       const scope = new Scope();
-      scope.setLevel(Severity.Warning);
+      scope.setLevel('warning' as Severity);
       const event: Event = {};
-      event.level = Severity.Critical;
+      event.level = 'critical' as Severity;
       return scope.applyToEvent(event).then(processedEvent => {
-        expect(processedEvent!.level).toEqual(Severity.Warning);
+        expect(processedEvent!.level).toEqual('warning' as Severity);
       });
     });
 
@@ -410,7 +410,7 @@ describe('Scope', () => {
       scope.setContext('foo', { id: '1' });
       scope.setContext('bar', { id: '2' });
       scope.setUser({ id: '1337' });
-      scope.setLevel(Severity.Info);
+      scope.setLevel('info' as Severity);
       scope.setFingerprint(['foo']);
       scope.setRequestSession({ status: 'ok' });
     });
@@ -458,7 +458,7 @@ describe('Scope', () => {
       localScope.setContext('bar', { id: '3' });
       localScope.setContext('baz', { id: '4' });
       localScope.setUser({ id: '42' });
-      localScope.setLevel(Severity.Warning);
+      localScope.setLevel('warning' as Severity);
       localScope.setFingerprint(['bar']);
       (localScope as any)._requestSession = { status: 'ok' };
 

diff --git a/packages/minimal/test/lib/minimal.test.ts b/packages/minimal/test/lib/minimal.test.ts
@@ -165,8 +165,8 @@ describe('Minimal', () => {
       const client: any = new TestClient({});
       const scope = getCurrentHub().pushScope();
       getCurrentHub().bindClient(client);
-      scope.setLevel(Severity.Warning);
-      expect(global.__SENTRY__.hub._stack[1].scope._level).toEqual(Severity.Warning);
+      scope.setLevel('warning' as Severity);
+      expect(global.__SENTRY__.hub._stack[1].scope._level).toEqual('warning' as Severity);
     });
   });
 
@@ -245,16 +245,16 @@ describe('Minimal', () => {
 
   test('withScope', () => {
     withScope(scope => {
-      scope.setLevel(Severity.Warning);
+      scope.setLevel('warning' as Severity);
       scope.setFingerprint(['1']);
       withScope(scope2 => {
-        scope2.setLevel(Severity.Info);
+        scope2.setLevel('info' as Severity);
         scope2.setFingerprint(['2']);
         withScope(scope3 => {
           scope3.clear();
-          expect(global.__SENTRY__.hub._stack[1].scope._level).toEqual(Severity.Warning);
+          expect(global.__SENTRY__.hub._stack[1].scope._level).toEqual('warning' as Severity);
           expect(global.__SENTRY__.hub._stack[1].scope._fingerprint).toEqual(['1']);
-          expect(global.__SENTRY__.hub._stack[2].scope._level).toEqual(Severity.Info);
+          expect(global.__SENTRY__.hub._stack[2].scope._level).toEqual('info' as Severity);
           expect(global.__SENTRY__.hub._stack[2].scope._fingerprint).toEqual(['2']);
           expect(global.__SENTRY__.hub._stack[3].scope._level).toBeUndefined();
         });

diff --git a/packages/node/src/backend.ts b/packages/node/src/backend.ts
@@ -22,7 +22,7 @@ export class NodeBackend extends BaseBackend<NodeOptions> {
   /**
    * @inheritDoc
    */
-  public eventFromMessage(message: string, level: Severity = Severity.Info, hint?: EventHint): PromiseLike<Event> {
+  public eventFromMessage(message: string, level: Severity = 'info' as Severity, hint?: EventHint): PromiseLike<Event> {
     return eventFromMessage(this._options, message, level, hint);
   }
 

diff --git a/packages/node/src/eventbuilder.ts b/packages/node/src/eventbuilder.ts
@@ -69,7 +69,7 @@ export function eventFromException(options: Options, exception: unknown, hint?:
 export function eventFromMessage(
   options: Options,
   message: string,
-  level: Severity = Severity.Info,
+  level: Severity = 'info' as Severity,
   hint?: EventHint,
 ): PromiseLike<Event> {
   const event: Event = {

diff --git a/packages/node/src/index.ts b/packages/node/src/index.ts
@@ -1,4 +1,4 @@
-export {
+export type {
   Breadcrumb,
   BreadcrumbHint,
   Request,
@@ -15,7 +15,9 @@ export {
   User,
 } from '@sentry/types';
 
-export { SeverityLevel } from '@sentry/utils';
+export type { SeverityLevel } from '@sentry/utils';
+
+export type { NodeOptions } from './types';
 
 export {
   addGlobalEventProcessor,
@@ -40,7 +42,6 @@ export {
   withScope,
 } from '@sentry/core';
 
-export { NodeOptions } from './types';
 export { NodeBackend } from './backend';
 export { NodeClient } from './client';
 export { defaultIntegrations, init, lastEventId, flush, close, getSentryRelease } from './sdk';

diff --git a/packages/node/src/integrations/onuncaughtexception.ts b/packages/node/src/integrations/onuncaughtexception.ts
@@ -77,7 +77,7 @@ export class OnUncaughtException implements Integration {
 
         if (hub.getIntegration(OnUncaughtException)) {
           hub.withScope((scope: Scope) => {
-            scope.setLevel(Severity.Fatal);
+            scope.setLevel('fatal' as Severity);
             hub.captureException(error, {
               originalException: error,
               data: { mechanism: { handled: false, type: 'onuncaughtexception' } },

diff --git a/packages/serverless/src/awslambda.ts b/packages/serverless/src/awslambda.ts
@@ -274,7 +274,7 @@ export function wrapHandler<TEvent, TResult>(
       timeoutWarningTimer = setTimeout(() => {
         withScope(scope => {
           scope.setTag('timeout', humanReadableTimeout);
-          captureMessage(`Possible function timeout: ${context.functionName}`, Sentry.Severity.Warning);
+          captureMessage(`Possible function timeout: ${context.functionName}`, 'warning' as Sentry.Severity);
         });
       }, timeoutWarningDelay);
     }

diff --git a/packages/serverless/src/gcpfunction/general.ts b/packages/serverless/src/gcpfunction/general.ts
@@ -62,4 +62,4 @@ export function configureScopeWithContext(scope: Scope, context: Context): void
   scope.setContext('gcp.function.context', { ...context } as SentryContext);
 }
 
-export { Request, Response };
+export type { Request, Response };
diff --git a/packages/tracing/src/browser/index.ts b/packages/tracing/src/browser/index.ts
@@ -1,6 +1,4 @@
+export type { RequestInstrumentationOptions } from './request';
+
 export { BrowserTracing } from './browsertracing';
-export {
-  instrumentOutgoingRequests,
-  RequestInstrumentationOptions,
-  defaultRequestInstrumentationOptions,
-} from './request';
+export { instrumentOutgoingRequests, defaultRequestInstrumentationOptions } from './request';
diff --git a/packages/tracing/src/index.bundle.ts b/packages/tracing/src/index.bundle.ts
@@ -1,4 +1,4 @@
-export {
+export type {
   Breadcrumb,
   Request,
   SdkInfo,
@@ -13,7 +13,9 @@ export {
   User,
 } from '@sentry/types';
 
-export { SeverityLevel } from '@sentry/utils';
+export type { BrowserOptions, ReportDialogOptions } from '@sentry/browser';
+
+export type { SeverityLevel } from '@sentry/utils';
 
 export {
   addGlobalEventProcessor,
@@ -37,8 +39,7 @@ export {
   withScope,
 } from '@sentry/browser';
 
-export { BrowserOptions } from '@sentry/browser';
-export { BrowserClient, ReportDialogOptions } from '@sentry/browser';
+export { BrowserClient } from '@sentry/browser';
 export {
   defaultIntegrations,
   forceLoad,

diff --git a/packages/tracing/src/index.ts b/packages/tracing/src/index.ts
@@ -1,6 +1,9 @@
 import { addExtensionMethods } from './hubextensions';
 import * as Integrations from './integrations';
 
+export type { RequestInstrumentationOptions } from './browser';
+export type { SpanStatusType } from './span';
+
 export { Integrations };
 
 // This is already exported as part of `Integrations` above (and for the moment will remain so for
@@ -21,14 +24,13 @@ export { Integrations };
 // For an example of of the new usage of BrowserTracing, see @sentry/nextjs index.client.ts
 export { BrowserTracing } from './browser';
 
-export { Span, SpanStatusType, spanStatusfromHttpCode } from './span';
+export { Span, spanStatusfromHttpCode } from './span';
 // eslint-disable-next-line deprecation/deprecation
 export { SpanStatus } from './spanstatus';
 export { Transaction } from './transaction';
 export {
   // TODO deprecate old name in v7
   instrumentOutgoingRequests as registerRequestInstrumentation,
-  RequestInstrumentationOptions,
   defaultRequestInstrumentationOptions,
 } from './browser';
 export { IdleTransaction } from './idletransaction';