Skip to content

Commit

Permalink
Merge pull request #14641 from getsentry/lforst-sp-lm
Browse files Browse the repository at this point in the history
  • Loading branch information
lforst authored Dec 11, 2024
2 parents 9913328 + 1998b8f commit 4ba5ae7
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 3 deletions.
2 changes: 1 addition & 1 deletion packages/node/test/integration/transactions.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -620,7 +620,7 @@ describe('Integration | Transactions', () => {
expect(logs).toEqual(
expect.arrayContaining([
'SpanExporter dropped 2 spans because they were pending for more than 300 seconds.',
'SpanExporter exported 1 spans, 0 unsent spans remaining',
'SpanExporter exported 1 spans, 0 spans are waiting for their parent spans to finish',
]),
);
});
Expand Down
4 changes: 3 additions & 1 deletion packages/opentelemetry/src/spanExporter.ts
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,9 @@ export class SentrySpanExporter {
const remainingOpenSpanCount = finishedSpans.length - sentSpanCount;

DEBUG_BUILD &&
logger.log(`SpanExporter exported ${sentSpanCount} spans, ${remainingOpenSpanCount} unsent spans remaining`);
logger.log(
`SpanExporter exported ${sentSpanCount} spans, ${remainingOpenSpanCount} spans are waiting for their parent spans to finish`,
);

sentSpans.forEach(span => {
const bucketEntry = this._spansToBucketEntry.get(span);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -500,7 +500,7 @@ describe('Integration | Transactions', () => {
expect(logs).toEqual(
expect.arrayContaining([
'SpanExporter dropped 2 spans because they were pending for more than 300 seconds.',
'SpanExporter exported 1 spans, 0 unsent spans remaining',
'SpanExporter exported 1 spans, 0 spans are waiting for their parent spans to finish',
]),
);
});
Expand Down

0 comments on commit 4ba5ae7

Please sign in to comment.