Skip to content

Commit

Permalink
ci: Ensure we check correctly for bot users (#13955)
Browse files Browse the repository at this point in the history
It seems that `github.actor` is not necessarily the PR author, but
possibly the user that merged the PR.

You can see e.g. here:
https://github.com/getsentry/sentry-javascript/actions/runs/11270299315/job/31340702772
how it still ran for a dependabot PR.
  • Loading branch information
mydea authored Oct 11, 2024
1 parent 10533fe commit 26ec075
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/external-contributors.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
&& github.event.pull_request.author_association != 'COLLABORATOR'
&& github.event.pull_request.author_association != 'MEMBER'
&& github.event.pull_request.author_association != 'OWNER'
&& endsWith(github.actor, '[bot]') == false
&& endsWith(github.event.pull_request.user.login, '[bot]') == false
steps:
- uses: actions/checkout@v4
- name: Set up Node
Expand Down

0 comments on commit 26ec075

Please sign in to comment.