fix: Use correct types for event context data

getsentry · Sep 29, 2020 · 150f7f2 · rhcarvalho · Sep 29, 2020 · kamilogorek
1 parent a575c83
commit 150f7f2
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 8 deletions.
diff --git a/packages/hub/src/scope.ts b/packages/hub/src/scope.ts
@@ -40,12 +40,10 @@ export class Scope implements ScopeInterface {
   protected _tags: { [key: string]: string } = {};
 
   /** Extra */
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any
-  protected _extra: { [key: string]: any } = {};
+  protected _extra: { [key: string]: unknown } = {};
 
   /** Contexts */
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any
-  protected _contexts: { [key: string]: any } = {};
+  protected _contexts: { [key: string]: Record<string, unknown> } = {};
 
   /** Fingerprint */
   protected _fingerprint?: string[];
@@ -185,9 +183,14 @@ export class Scope implements ScopeInterface {
   /**
    * @inheritDoc
    */
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any
-  public setContext(key: string, context: { [key: string]: any } | null): this {
-    this._contexts = { ...this._contexts, [key]: context };
+  public setContext(key: string, context: Record<string, unknown> | null): this {
+    if (context === null) {
+      // eslint-disable-next-line @typescript-eslint/no-dynamic-delete
+      delete this._contexts[key];
+    } else {
+      this._contexts = { ...this._contexts, [key]: context };
+    }
+
     this._notifyScopeListeners();
     return this;
   }

diff --git a/packages/types/src/scope.ts b/packages/types/src/scope.ts
@@ -14,7 +14,7 @@ export interface ScopeContext {
   user: User;
   level: Severity;
   extra: { [key: string]: any };
-  contexts: { [key: string]: any };
+  contexts: { [key: string]: Record<any, any> };
   tags: { [key: string]: string };
   fingerprint: string[];
 }