Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POTEL 70 - Add sentry-opentelemetry-agentless-spring module #4000

Open
wants to merge 4 commits into
base: feat/otel-span-strongref
Choose a base branch
from

Conversation

adinauer
Copy link
Member

📜 Description

Add sentry-opentelemetry-agentless-spring module

💡 Motivation and Context

So we can bring the right version of opentelemetry-spring-boot-starter and also add a marker which can then later be detected for auto configuration.

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

github-actions bot commented Dec 18, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 11bff06

Copy link
Contributor

github-actions bot commented Dec 18, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 412.59 ms 444.34 ms 31.75 ms
Size 1.65 MiB 2.31 MiB 677.05 KiB

Baseline results on branch: feat/otel-span-strongref

Startup times

Revision Plain With Sentry Diff
33c9aac 393.47 ms 407.26 ms 13.79 ms
b387fed 417.02 ms 519.06 ms 102.04 ms
c658b5a 410.55 ms 461.18 ms 50.63 ms

App size

Revision Plain With Sentry Diff
33c9aac 1.65 MiB 2.31 MiB 677.05 KiB
b387fed 1.65 MiB 2.31 MiB 677.07 KiB
c658b5a 1.65 MiB 2.31 MiB 677.05 KiB

Previous results on branch: feat/agentless-spring-module

Startup times

Revision Plain With Sentry Diff
075e242 648.35 ms 728.38 ms 80.03 ms

App size

Revision Plain With Sentry Diff
075e242 1.65 MiB 2.31 MiB 677.07 KiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant