Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not report parsing ANR error when there are no threads #3888

Merged
merged 7 commits into from
Nov 14, 2024

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented Nov 13, 2024

📜 Description

Previously we would be sending a message that parsing the ANRs dump was unsuccessful, but now we only do it for the case when there's an actual error in parsing - if there are simply no matching entries in a thread dump and the returned thread list is empty, we just don't do anything. Seems like Google Play and Firebase also ignore these kind of ANRs.

💚 How did you test it?

Automated

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

github-actions bot commented Nov 13, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 445.74 ms 526.10 ms 80.37 ms
Size 1.70 MiB 2.35 MiB 668.77 KiB

@romtsn romtsn enabled auto-merge (squash) November 14, 2024 09:52
@romtsn romtsn merged commit a183163 into main Nov 14, 2024
33 checks passed
@romtsn romtsn deleted the rz/fix/do-not-report-bad-data-anrs branch November 14, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants