Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-enable flaky test #3884

Merged
merged 2 commits into from
Nov 13, 2024
Merged

re-enable flaky test #3884

merged 2 commits into from
Nov 13, 2024

Conversation

adinauer
Copy link
Member

@adinauer adinauer commented Nov 13, 2024

#skip-changelog

📜 Description

💡 Motivation and Context

Closes #3872

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

github-actions bot commented Nov 13, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 0aebf8e

Copy link
Contributor

github-actions bot commented Nov 13, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 397.56 ms 494.56 ms 97.00 ms
Size 1.65 MiB 2.31 MiB 673.46 KiB

Previous results on branch: feat/re-enable-flaky-test

Startup times

Revision Plain With Sentry Diff
7480d53 500.33 ms 522.84 ms 22.51 ms

App size

Revision Plain With Sentry Diff
7480d53 1.65 MiB 2.31 MiB 673.06 KiB

@adinauer adinauer merged commit 40235f5 into 8.x.x Nov 13, 2024
3 checks passed
@adinauer adinauer deleted the feat/re-enable-flaky-test branch November 13, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants