Fix: Allow MaxBreadcrumb 0 / Expose MaxBreadcrumb metadata. #3836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 30, 2024 20:31
… maxbreadcrumbs sets to 0
lucas-zimerman
requested review from
adinauer,
romtsn,
stefanosiano and
markushi
as code owners
sentry-android-core/src/test/java/io/sentry/android/core/ManifestMetadataReaderTest.kt
Outdated
Show resolved
Hide resolved
sentry-android-core/src/test/java/io/sentry/android/core/ManifestMetadataReaderTest.kt
Outdated
Show resolved
Hide resolved
…estMetadataReaderTest.kt Co-authored-by: Stefano <[email protected]>
…estMetadataReaderTest.kt Co-authored-by: Stefano <[email protected]>
|
@stefanosiano just saying that I cannot merge PRs here, do we need to wait for more approvals before merging it? |
|
yeah, thanks for the reminder 😅 |
adinauer
reviewed
Nov 13, 2024
| */ | ||
| @Override | ||
| public boolean isEmpty() { | ||
| return false; |
There was a problem hiding this comment.
@lucas-zimerman @stefanosiano should this return true instead? If no, can we document why?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Previously, when MaxBreadcrumbs was set to 0, the app would crash since the CircularQueue implementation must have a size higher than 0.
With that, I made a
disabledqueuethat behaves similarly likeCircularQueuedo, with the difference that any items inserted into it will be ignored.💡 Motivation and Context
I was also surprised to see that max breadcrumbs wasn't exposed on the metadata, so I also exposed it on this PR to make tests with the sample easier.
To fix
getsentry/sentry-react-native#3634
and
#3313
💚 How did you test it?
Unit tests and running the sample app with max breadcrumbs set to 0 and 100.
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps