Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ANRv2 test flakyness #3798

Merged
merged 2 commits into from
Oct 16, 2024
Merged

Fix ANRv2 test flakyness #3798

merged 2 commits into from
Oct 16, 2024

Conversation

stefanosiano
Copy link
Member

📜 Description

#skip-changelog

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 16, 2024 •
edited
Loading

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 430.49 ms 481.47 ms 50.98 ms
Size 1.70 MiB 2.35 MiB 668.04 KiB

Previous results on branch: fix/flaky-anrv2-unit-test

Startup times

Revision Plain With Sentry Diff
2ac50bc 405.22 ms 409.60 ms 4.38 ms

App size

Revision Plain With Sentry Diff
2ac50bc 1.70 MiB 2.35 MiB 668.04 KiB

@stefanosiano stefanosiano marked this pull request as ready for review October 16, 2024 16:11
@stefanosiano
Copy link
Member Author

i tried running the test in CI 4 times, and it always passed
hopefully it's not just a coincidence 😅

romtsn
romtsn approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@romtsn romtsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a bit weird that this has fixed it but I trust you :D

@romtsn romtsn merged commit bd82483 into main Oct 16, 2024
29 checks passed
@romtsn romtsn deleted the fix/flaky-anrv2-unit-test branch October 16, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romtsn romtsn romtsn approved these changes

@adinauer adinauer Awaiting requested review from adinauer adinauer is a code owner

@markushi markushi Awaiting requested review from markushi markushi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stefanosiano @romtsn