[QA] Make logging faster on startup #3793
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
String.format
vs plus-operator, andString.format
is indeed slower.debug
is set tofalse
, this was adding some overhead. I've removed the redundant log call + add changedString.format
usages to the plus operatorString.format
even when there are no args passed, so we check for their presence now and call the method withoutString.format
explicitly nowBefore
After
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps