-
-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add timestamp when a profile starts #3442
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added the timestamp in ProfilingTraceData and send it in the json payload
stefanosiano
changed the title
added start timestamp in ProfileStartData when a profile starts
Add timestamp when a profile starts
May 24, 2024
It looks like there is something wrong, as changes are not reflected in the flamechart in Sentry. I'll keep it as a draft until further investigation. |
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
d6d2b2e | 463.14 ms | 545.56 ms | 82.42 ms |
a3c77bc | 375.80 ms | 445.85 ms | 70.06 ms |
c7e2fbc | 377.85 ms | 426.35 ms | 48.50 ms |
f5e1b97 | 362.53 ms | 429.31 ms | 66.78 ms |
7eccfdb | 389.94 ms | 461.29 ms | 71.35 ms |
f1fdb9f | 404.21 ms | 496.87 ms | 92.66 ms |
28c9a83 | 346.14 ms | 377.76 ms | 31.62 ms |
baaf637 | 375.71 ms | 441.58 ms | 65.87 ms |
283d83e | 348.44 ms | 392.06 ms | 43.62 ms |
61981dc | 388.65 ms | 454.96 ms | 66.31 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
d6d2b2e | 1.72 MiB | 2.27 MiB | 555.05 KiB |
a3c77bc | 1.72 MiB | 2.29 MiB | 577.53 KiB |
c7e2fbc | 1.72 MiB | 2.29 MiB | 576.40 KiB |
f5e1b97 | 1.70 MiB | 2.28 MiB | 592.00 KiB |
7eccfdb | 1.72 MiB | 2.27 MiB | 556.93 KiB |
f1fdb9f | 1.70 MiB | 2.28 MiB | 592.08 KiB |
28c9a83 | 1.70 MiB | 2.28 MiB | 592.00 KiB |
baaf637 | 1.72 MiB | 2.27 MiB | 558.42 KiB |
283d83e | 1.72 MiB | 2.29 MiB | 577.69 KiB |
61981dc | 1.70 MiB | 2.28 MiB | 592.12 KiB |
frontend was updated, and now everything works as expected |
markushi
approved these changes
Jun 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
added start timestamp in ProfileStartData when a profile starts
added the timestamp in ProfilingTraceData and send it in the json payload
Example of wrong profile (before)
Example of correct profile (after)
💡 Motivation and Context
Profiles are a not aligned to spans, especially when we change the transaction start timestamp. In that case, it is assumed that the profile and the transaction starts at the same time, which is wrong. I added a
timestamp
field set when the profile starts.💚 How did you test it?
Unit tests
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps