Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not always write startup crash marker #3409

Merged
merged 3 commits into from
May 8, 2024
Merged

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented May 7, 2024

📜 Description

  • We were using epoch millis for startup time, whereas CurrentDateProvider uses uptime millis, therefore we were always writing the crash marker file and always blocking SDK init. This is a regression from when we introduced app start spans

💡 Motivation and Context

Found out this accidentally while testing

💚 How did you test it?

Manually + automated

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

github-actions bot commented May 7, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 387.15 ms 431.16 ms 44.01 ms
Size 1.70 MiB 2.28 MiB 592.08 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
0404ea3 394.73 ms 461.79 ms 67.06 ms
d007225 365.63 ms 438.24 ms 72.62 ms
c7e2fbc 372.00 ms 461.71 ms 89.71 ms
8838e01 387.41 ms 467.00 ms 79.59 ms
4e29063 384.14 ms 447.74 ms 63.60 ms
4e260b3 388.40 ms 468.98 ms 80.58 ms
c7e2fbc 393.98 ms 478.24 ms 84.27 ms
95a98b5 379.14 ms 420.80 ms 41.66 ms
a33b076 390.44 ms 460.29 ms 69.85 ms
2465853 422.61 ms 491.20 ms 68.58 ms

App size

Revision Plain With Sentry Diff
0404ea3 1.72 MiB 2.29 MiB 577.52 KiB
d007225 1.70 MiB 2.27 MiB 586.31 KiB
c7e2fbc 1.72 MiB 2.29 MiB 576.40 KiB
8838e01 1.72 MiB 2.29 MiB 578.15 KiB
4e29063 1.72 MiB 2.29 MiB 578.38 KiB
4e260b3 1.72 MiB 2.27 MiB 554.95 KiB
c7e2fbc 1.72 MiB 2.29 MiB 576.40 KiB
95a98b5 1.70 MiB 2.27 MiB 586.31 KiB
a33b076 1.70 MiB 2.28 MiB 592.32 KiB
2465853 1.70 MiB 2.27 MiB 583.82 KiB

Previous results on branch: rz/fix/startup-crashes

Startup times

Revision Plain With Sentry Diff
efa6151 367.69 ms 448.24 ms 80.55 ms
86cead6 386.86 ms 476.00 ms 89.14 ms

App size

Revision Plain With Sentry Diff
efa6151 1.70 MiB 2.28 MiB 592.14 KiB
86cead6 1.70 MiB 2.28 MiB 592.14 KiB

@romtsn romtsn enabled auto-merge (squash) May 8, 2024 10:46
@romtsn romtsn merged commit d83be50 into main May 8, 2024
23 of 24 checks passed
@romtsn romtsn deleted the rz/fix/startup-crashes branch May 8, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants