Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ttid/ttfd contribution flags #3386

Merged
merged 7 commits into from
May 3, 2024

Conversation

markushi
Copy link
Member

📜 Description

Attaches the ttid/ttfd contribution flags to all spans within a txn, if the txn contains a ttid/ttfd span.

💡 Motivation and Context

Relevant docs PR: https://github.com/getsentry/develop/pull/1250/files
Relevant discussion on Notion: https://www.notion.so/sentry/span-contribution-9b5a0979a81645789db6877593729cf4

💚 How did you test it?

Added tests

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

github-actions bot commented Apr 26, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 7a040c0

Copy link
Contributor

github-actions bot commented Apr 26, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 403.85 ms 471.84 ms 67.98 ms
Size 1.70 MiB 2.28 MiB 592.53 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
0810952 364.51 ms 468.08 ms 103.57 ms
61981dc 388.65 ms 454.96 ms 66.31 ms
baaf637 428.12 ms 520.40 ms 92.28 ms
1ae2ec6 353.85 ms 419.71 ms 65.85 ms
c7e2fbc 377.85 ms 426.35 ms 48.50 ms
b172d4e 412.60 ms 492.68 ms 80.08 ms
4e260b3 378.73 ms 454.18 ms 75.45 ms
93a76ca 377.41 ms 448.22 ms 70.81 ms
93a76ca 381.08 ms 459.22 ms 78.14 ms
7b7964f 363.27 ms 455.32 ms 92.05 ms

App size

Revision Plain With Sentry Diff
0810952 1.72 MiB 2.27 MiB 558.21 KiB
61981dc 1.70 MiB 2.28 MiB 592.12 KiB
baaf637 1.72 MiB 2.27 MiB 558.42 KiB
1ae2ec6 1.70 MiB 2.27 MiB 584.63 KiB
c7e2fbc 1.72 MiB 2.29 MiB 576.40 KiB
b172d4e 1.72 MiB 2.29 MiB 578.09 KiB
4e260b3 1.72 MiB 2.27 MiB 554.95 KiB
93a76ca 1.72 MiB 2.29 MiB 576.75 KiB
93a76ca 1.72 MiB 2.29 MiB 576.75 KiB
7b7964f 1.70 MiB 2.28 MiB 592.12 KiB

Previous results on branch: feat/app-start-ttid-ttfd-span-tagging

Startup times

Revision Plain With Sentry Diff
4fa2c56 403.10 ms 527.82 ms 124.72 ms
6a610ad 384.41 ms 441.60 ms 57.19 ms

App size

Revision Plain With Sentry Diff
4fa2c56 1.70 MiB 2.28 MiB 592.53 KiB
6a610ad 1.70 MiB 2.28 MiB 592.50 KiB

continue;
}

// TODO should we only consider spans running on the main thread?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably: for TTID - yes, for TTFD - no, also should consider background ones

Copy link
Member

@romtsn romtsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@markushi markushi merged commit 8045023 into main May 3, 2024
24 checks passed
@markushi markushi deleted the feat/app-start-ttid-ttfd-span-tagging branch May 3, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants