-
-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove HostnameVerifier option #3150
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romtsn
requested review from
adinauer,
stefanosiano and
markushi
as code owners
January 18, 2024 09:15
@bitsandfoxes the problem is gonna resolve itself after merging :P |
kahest
reviewed
Jan 18, 2024
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
b172d4e | 413.47 ms | 479.02 ms | 65.55 ms |
bc4be3b | 360.40 ms | 435.04 ms | 74.64 ms |
7eccfdb | 389.94 ms | 461.29 ms | 71.35 ms |
7eccfdb | 366.98 ms | 440.27 ms | 73.29 ms |
4e260b3 | 388.40 ms | 468.98 ms | 80.58 ms |
8838e01 | 387.41 ms | 467.00 ms | 79.59 ms |
c7e2fbc | 398.35 ms | 468.52 ms | 70.17 ms |
d6d2b2e | 463.14 ms | 545.56 ms | 82.42 ms |
93a76ca | 397.30 ms | 455.16 ms | 57.87 ms |
0bd723b | 412.52 ms | 496.65 ms | 84.13 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
b172d4e | 1.72 MiB | 2.29 MiB | 578.09 KiB |
bc4be3b | 1.72 MiB | 2.29 MiB | 576.53 KiB |
7eccfdb | 1.72 MiB | 2.27 MiB | 556.93 KiB |
7eccfdb | 1.72 MiB | 2.27 MiB | 556.93 KiB |
4e260b3 | 1.72 MiB | 2.27 MiB | 554.95 KiB |
8838e01 | 1.72 MiB | 2.29 MiB | 578.15 KiB |
c7e2fbc | 1.72 MiB | 2.29 MiB | 576.40 KiB |
d6d2b2e | 1.72 MiB | 2.27 MiB | 555.05 KiB |
93a76ca | 1.72 MiB | 2.29 MiB | 576.75 KiB |
0bd723b | 1.72 MiB | 2.29 MiB | 578.09 KiB |
romtsn
commented
Jan 18, 2024
adinauer
approved these changes
Jan 18, 2024
which exactly?
https://github.com/getsentry/sentry-java/releases/tag/7.3.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
This was mainly used by self-hosted users who has a self-signed certificate. There will be 3 options for them going forward:
ITransportFactory
, where they can copy over most parts likeHttpConnection
andAsyncHttpTransport
with necessary modificationsIt's a breaking change, but we agreed that the impact is gonna be so small that it's not worth waiting for the next major, given that it produces so many false positives by security tools of some app stores
💡 Motivation and Context
Closes getsentry/sentry-unity#1513
💚 How did you test it?
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps