Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add slow and frozen frames span data conventions #3086

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

markushi
Copy link
Member

@markushi markushi commented Dec 6, 2023

📜 Description

Add slow and frozen frame keys to span conventions, as per https://github.com/getsentry/develop/pull/1099/files

#skip-changelog

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

github-actions bot commented Dec 6, 2023

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against d2947d1

Copy link
Contributor

github-actions bot commented Dec 6, 2023

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 393.67 ms 482.90 ms 89.23 ms
Size 1.72 MiB 2.27 MiB 554.95 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
0404ea3 332.47 ms 401.12 ms 68.66 ms
2a3dd50 363.61 ms 440.18 ms 76.57 ms
7ca9895 364.31 ms 460.46 ms 96.15 ms
c7e2fbc 393.98 ms 478.24 ms 84.27 ms
4e29063 384.14 ms 447.74 ms 63.60 ms
0bd723b 375.20 ms 452.41 ms 77.20 ms
8838e01 367.65 ms 447.40 ms 79.75 ms
86f0096 368.63 ms 446.92 ms 78.29 ms
93a76ca 377.96 ms 447.52 ms 69.56 ms
4e29063 376.38 ms 390.98 ms 14.60 ms

App size

Revision Plain With Sentry Diff
0404ea3 1.72 MiB 2.29 MiB 577.52 KiB
2a3dd50 1.72 MiB 2.27 MiB 555.05 KiB
7ca9895 1.72 MiB 2.29 MiB 576.51 KiB
c7e2fbc 1.72 MiB 2.29 MiB 576.40 KiB
4e29063 1.72 MiB 2.29 MiB 578.38 KiB
0bd723b 1.72 MiB 2.29 MiB 578.09 KiB
8838e01 1.72 MiB 2.29 MiB 578.15 KiB
86f0096 1.72 MiB 2.29 MiB 576.50 KiB
93a76ca 1.72 MiB 2.29 MiB 576.75 KiB
4e29063 1.72 MiB 2.29 MiB 578.38 KiB

Copy link
Contributor

@buenaflor buenaflor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@markushi markushi merged commit cd2d55d into main Dec 12, 2023
20 checks passed
@markushi markushi deleted the feat/span-convention-slow-frozen-frames branch December 12, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants