Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve thresholds for network changes breadcrumbs #3083

Merged
merged 4 commits into from
Dec 21, 2023

Conversation

stefanosiano
Copy link
Member

📜 Description

added a threshold for network changes breadcrumbs of 5 seconds for signal strength and bandwidth.
added a 10% threshold for bandwidth, other than 1000 absolute threshold

💡 Motivation and Context

We've seen some transactions with a lot of breadcrumbs (almost 10 in a second) being sent due to bandwidth changes.
Since this is not a vital info, we're making sure to send at most 1 breadcrumb every 5 seconds for signal strength and bandwidth changes.
Changes in connection type and vpn status will ignore this time threshold

💚 How did you test it?

Unit tests

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

…gnal strength and bandwidth.

added a 10% threshold for bandwidth, other than 1000 absolute threshold
@stefanosiano stefanosiano marked this pull request as ready for review December 5, 2023 11:55
Copy link
Contributor

github-actions bot commented Dec 5, 2023

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 394.71 ms 456.87 ms 62.16 ms
Size 1.72 MiB 2.27 MiB 558.42 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
8838e01 387.41 ms 467.00 ms 79.59 ms
4e260b3 384.08 ms 477.56 ms 93.48 ms
93a76ca 377.41 ms 448.22 ms 70.81 ms
0bd723b 375.20 ms 452.41 ms 77.20 ms
86f0096 368.63 ms 446.92 ms 78.29 ms
0404ea3 332.47 ms 401.12 ms 68.66 ms
b172d4e 412.60 ms 492.68 ms 80.08 ms
93a76ca 397.30 ms 455.16 ms 57.87 ms
8ff8fd0 432.77 ms 495.18 ms 62.41 ms
7eccfdb 389.94 ms 461.29 ms 71.35 ms

App size

Revision Plain With Sentry Diff
8838e01 1.72 MiB 2.29 MiB 578.15 KiB
4e260b3 1.72 MiB 2.27 MiB 554.95 KiB
93a76ca 1.72 MiB 2.29 MiB 576.75 KiB
0bd723b 1.72 MiB 2.29 MiB 578.09 KiB
86f0096 1.72 MiB 2.29 MiB 576.50 KiB
0404ea3 1.72 MiB 2.29 MiB 577.52 KiB
b172d4e 1.72 MiB 2.29 MiB 578.09 KiB
93a76ca 1.72 MiB 2.29 MiB 576.75 KiB
8ff8fd0 1.72 MiB 2.27 MiB 558.15 KiB
7eccfdb 1.72 MiB 2.27 MiB 556.93 KiB

Previous results on branch: enh/network-changes-thresholds

Startup times

Revision Plain With Sentry Diff
eca626c 380.96 ms 468.35 ms 87.39 ms
e08707d 400.57 ms 503.06 ms 102.49 ms

App size

Revision Plain With Sentry Diff
eca626c 1.72 MiB 2.27 MiB 555.27 KiB
e08707d 1.72 MiB 2.27 MiB 555.27 KiB

Copy link
Member

@markushi markushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@stefanosiano stefanosiano merged commit d429384 into main Dec 21, 2023
17 of 19 checks passed
@stefanosiano stefanosiano deleted the enh/network-changes-thresholds branch December 21, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants