Improve thresholds for network changes breadcrumbs #3083
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
added a threshold for network changes breadcrumbs of 5 seconds for signal strength and bandwidth.
added a 10% threshold for bandwidth, other than 1000 absolute threshold
💡 Motivation and Context
We've seen some transactions with a lot of breadcrumbs (almost 10 in a second) being sent due to bandwidth changes.
Since this is not a vital info, we're making sure to send at most 1 breadcrumb every 5 seconds for signal strength and bandwidth changes.
Changes in connection type and vpn status will ignore this time threshold
💚 How did you test it?
Unit tests
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps