Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect maxSpans for nested child spans #3065

Merged
merged 4 commits into from
Nov 27, 2023
Merged

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented Nov 27, 2023

📜 Description

💡 Motivation and Context

Closes #3058

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Member

@markushi markushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a minor concern.

sentry/src/main/java/io/sentry/SentryTracer.java Outdated Show resolved Hide resolved
Copy link
Contributor

github-actions bot commented Nov 27, 2023

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 348.32 ms 419.16 ms 70.84 ms
Size 1.72 MiB 2.26 MiB 552.77 KiB

Baseline results on branch: feat/7.0.0

Startup times

Revision Plain With Sentry Diff
362a653 391.00 ms 432.98 ms 41.98 ms
6a40795 370.00 ms 437.33 ms 67.33 ms
db8763d 386.60 ms 453.66 ms 67.06 ms
4355d78 377.47 ms 442.96 ms 65.49 ms
6684058 414.76 ms 511.46 ms 96.70 ms
d134818 371.35 ms 436.22 ms 64.87 ms
ff784c6 388.51 ms 461.90 ms 73.39 ms

App size

Revision Plain With Sentry Diff
362a653 1.72 MiB 2.26 MiB 551.33 KiB
6a40795 1.72 MiB 2.26 MiB 550.26 KiB
db8763d 1.72 MiB 2.26 MiB 550.22 KiB
4355d78 1.72 MiB 2.26 MiB 551.33 KiB
6684058 1.72 MiB 2.26 MiB 550.19 KiB
d134818 1.72 MiB 2.26 MiB 551.33 KiB
ff784c6 1.72 MiB 2.26 MiB 550.22 KiB

Previous results on branch: rz/fix/maxspans-nested

Startup times

Revision Plain With Sentry Diff
b7834d0 365.46 ms 433.39 ms 67.93 ms

App size

Revision Plain With Sentry Diff
b7834d0 1.72 MiB 2.26 MiB 552.77 KiB

@romtsn romtsn merged commit eb245c4 into feat/7.0.0 Nov 27, 2023
16 checks passed
@romtsn romtsn deleted the rz/fix/maxspans-nested branch November 27, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants