Fix crash accessing Choreographer instance

[stefanosiano]

📜 Description

choreographer instance is now retrieved in a try/catch block, due to a crash reported by Google Play SDK console

💡 Motivation and Context

Fixes a crash. Closes #2912

💚 How did you test it?

📝 Checklist

• I reviewed the submitted code.
• I added tests to verify the changes.
• No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
• I updated the docs if needed.
• Review from the native team if needed.
• No breaking change or entry added to the changelog.
• No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

[github-actions]

Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	378.18 ms	471.90 ms	93.72 ms
Size	1.72 MiB	2.29 MiB	576.36 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
4d55d51	389.44 ms	471.55 ms	82.11 ms

App size

Revision	Plain	With Sentry	Diff
4d55d51	1.72 MiB	2.29 MiB	576.34 KiB

[codecov]

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Files	Coverage Δ
...ore/internal/util/SentryFrameMetricsCollector.java	67.18% <55.55%> (-1.15%)	⬇️

📢 Thoughts on this report? Let us know!.

[markushi]

LGTM, please check my comment!

[markushi]

Since choregrapher is accessed via a handler outside the main thread I think it's a good idea to mark the field as volatile as well.

[stefanosiano]

I'm not sure, since it's only set once and read multiple times. We'd lose memory cache for that.
In the worst case now, when it's read it's still null, so the frame start will fallback to now - frameDuration