Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CheckInUtils.withCheckIn which abstracts away some of the manual check-ins complexity #2959

Merged
merged 2 commits into from
Oct 3, 2023

Conversation

adinauer
Copy link
Member

@adinauer adinauer commented Sep 29, 2023

📜 Description

A util class that send a check-in (IN_PROGRESS) before the code being passed in is executed and another check-in (OK or ERROR) once the code has completed. It also starts a new trace.

💡 Motivation and Context

Simplifies manual check-ins.

💚 How did you test it?

Manually + unit tests

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Sep 29, 2023

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 6d6543d

@github-actions
Copy link
Contributor

github-actions bot commented Sep 29, 2023

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 397.06 ms 478.61 ms 81.55 ms
Size 1.72 MiB 2.29 MiB 575.97 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
9e60fc1 283.04 ms 324.09 ms 41.04 ms
496bdfd 272.86 ms 407.33 ms 134.48 ms
9e60fc1 310.37 ms 359.48 ms 49.11 ms
496bdfd 301.22 ms 343.96 ms 42.73 ms
87b3774 310.48 ms 362.04 ms 51.56 ms
9e60fc1 334.08 ms 380.00 ms 45.92 ms
4bf202b 331.20 ms 345.24 ms 14.04 ms
9e60fc1 337.84 ms 385.24 ms 47.40 ms
adf8fe3 300.49 ms 357.36 ms 56.87 ms
9e60fc1 308.22 ms 361.72 ms 53.50 ms

App size

Revision Plain With Sentry Diff
9e60fc1 1.72 MiB 2.29 MiB 575.91 KiB
496bdfd 1.72 MiB 2.28 MiB 571.82 KiB
9e60fc1 1.72 MiB 2.29 MiB 575.91 KiB
496bdfd 1.72 MiB 2.28 MiB 571.82 KiB
87b3774 1.72 MiB 2.29 MiB 575.54 KiB
9e60fc1 1.72 MiB 2.29 MiB 575.91 KiB
4bf202b 1.72 MiB 2.29 MiB 575.54 KiB
9e60fc1 1.72 MiB 2.29 MiB 575.91 KiB
adf8fe3 1.72 MiB 2.29 MiB 575.24 KiB
9e60fc1 1.72 MiB 2.29 MiB 575.91 KiB

Previous results on branch: feat/crons-wrapper

Startup times

Revision Plain With Sentry Diff
84b81c5 419.26 ms 460.56 ms 41.30 ms

App size

Revision Plain With Sentry Diff
84b81c5 1.72 MiB 2.29 MiB 575.97 KiB

@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

All modified lines are covered by tests ✅

Files Coverage Δ
...try/src/main/java/io/sentry/util/CheckInUtils.java 92.59% <100.00%> (+9.25%) ⬆️

... and 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!.

Copy link
Collaborator

@lbloder lbloder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@adinauer adinauer merged commit a10bf9f into main Oct 3, 2023
20 checks passed
@adinauer adinauer deleted the feat/crons-wrapper branch October 3, 2023 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants