-
-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Capture unfinished transactions on crash #2938
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
44bf90b | 370.62 ms | 459.12 ms | 88.50 ms |
42bd05f | 321.19 ms | 365.20 ms | 44.01 ms |
6ee2c19 | 324.79 ms | 362.37 ms | 37.58 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
44bf90b | 1.72 MiB | 2.26 MiB | 548.19 KiB |
42bd05f | 1.72 MiB | 2.26 MiB | 547.88 KiB |
6ee2c19 | 1.72 MiB | 2.26 MiB | 547.91 KiB |
romtsn
requested review from
adinauer,
stefanosiano and
markushi
as code owners
September 18, 2023 15:04
adinauer
approved these changes
Sep 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there's no problem with the code where I added an assumption this LGTM after giving it a quick pass.
stefanosiano
approved these changes
Sep 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
UncaughtExceptionHint
reference if we know there's an active transaction on scope. This transaction will then use the hint to callmarkFlushed
and unblock the main thread once its serialization is done, which happens after the crash has been already serializedPreviously this was possible only if you capture exceptions manually:
💡 Motivation and Context
Closes #2316
💚 How did you test it?
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps