Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start a new automatic transaction on every click #2891

Merged
merged 2 commits into from
Aug 11, 2023

Conversation

markushi
Copy link
Member

@markushi markushi commented Aug 8, 2023

Adapt click user interaction behavior to JS: launch new transaction on every click.
Scroll and swipes behavior stays unchanged.

💡 Motivation and Context

Fixes #2594

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against e4c256c

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 303.41 ms 341.58 ms 38.17 ms
Size 1.72 MiB 2.29 MiB 576.58 KiB

Previous results on branch: feat/new-transaction-every-click

Startup times

Revision Plain With Sentry Diff
d2227c9 302.33 ms 346.12 ms 43.79 ms

App size

Revision Plain With Sentry Diff
d2227c9 1.72 MiB 2.29 MiB 576.58 KiB

Copy link
Member

@romtsn romtsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great changelog entry 👍

@markushi markushi merged commit 55b103c into feat/7.0.0 Aug 11, 2023
14 checks passed
@markushi markushi deleted the feat/new-transaction-every-click branch August 11, 2023 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants