-
-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update coroutines to 1.6.1, use CopyableThreadContextElement #2838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
d682eed | 289.13 ms | 322.75 ms | 33.63 ms |
43c30e9 | 345.22 ms | 401.72 ms | 56.50 ms |
d2a1d03 | 300.27 ms | 347.45 ms | 47.18 ms |
01793af | 308.04 ms | 345.98 ms | 37.94 ms |
d991728 | 306.22 ms | 379.98 ms | 73.76 ms |
4832bff | 296.70 ms | 345.86 ms | 49.16 ms |
38dab75 | 307.74 ms | 363.86 ms | 56.12 ms |
87a9528 | 313.35 ms | 357.31 ms | 43.96 ms |
699fd55 | 291.17 ms | 315.34 ms | 24.17 ms |
5679b98 | 304.72 ms | 340.31 ms | 35.59 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
d682eed | 1.72 MiB | 2.29 MiB | 575.24 KiB |
43c30e9 | 1.72 MiB | 2.29 MiB | 575.24 KiB |
d2a1d03 | 1.72 MiB | 2.29 MiB | 575.30 KiB |
01793af | 1.72 MiB | 2.29 MiB | 575.24 KiB |
d991728 | 1.72 MiB | 2.29 MiB | 575.24 KiB |
4832bff | 1.72 MiB | 2.29 MiB | 575.24 KiB |
38dab75 | 1.72 MiB | 2.29 MiB | 575.57 KiB |
87a9528 | 1.72 MiB | 2.29 MiB | 575.24 KiB |
699fd55 | 1.72 MiB | 2.29 MiB | 575.24 KiB |
5679b98 | 1.72 MiB | 2.29 MiB | 575.24 KiB |
adinauer
reviewed
Jul 12, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## feat/7.0.0 #2838 +/- ##
================================================
+ Coverage 81.26% 81.41% +0.15%
- Complexity 4560 4647 +87
================================================
Files 350 354 +4
Lines 16866 17108 +242
Branches 2272 2313 +41
================================================
+ Hits 13706 13929 +223
- Misses 2219 2230 +11
- Partials 941 949 +8
☔ View full report in Codecov by Sentry. |
lbloder
changed the title
update coroutines to 1.7.1, use CopyableThreadContextElement
update coroutines to 1.6.1, use CopyableThreadContextElement
Jul 13, 2023
# Conflicts: # CHANGELOG.md
adinauer
reviewed
Jul 14, 2023
adinauer
reviewed
Jul 17, 2023
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Use
CopyableThreadContextElement
as superclass forSentryContext
.💡 Motivation and Context
Fixes #2687.
Allows for correct progagation of the
SentryContext
to child-coroutines.Context propagation now behaves as described in the docs here: https://docs.sentry.io/platforms/java/guides/spring/enriching-events/scopes/#usage
💚 How did you test it?
Automated Unit Test
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps