Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix concurrent access to frameMetrics listener #2823

Merged
merged 3 commits into from
Jul 10, 2023

Conversation

stefanosiano
Copy link
Member

📜 Description

changed metrics listener map from HashMap to ConcurrentHashMap

💡 Motivation and Context

Fixes #2816

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 302.02 ms 350.94 ms 48.92 ms
Size 1.72 MiB 2.29 MiB 575.03 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
f274c79 313.96 ms 355.96 ms 42.00 ms
9246ed4 281.79 ms 352.08 ms 70.29 ms
9246ed4 275.63 ms 321.31 ms 45.69 ms
dc67004 273.86 ms 346.37 ms 72.51 ms
496bdfd 301.22 ms 343.96 ms 42.73 ms
8820c5c 330.60 ms 416.86 ms 86.26 ms
496bdfd 272.86 ms 407.33 ms 134.48 ms
c03a05e 390.40 ms 419.35 ms 28.94 ms
0310da5 381.20 ms 404.50 ms 23.30 ms

App size

Revision Plain With Sentry Diff
f274c79 1.72 MiB 2.29 MiB 575.01 KiB
9246ed4 1.72 MiB 2.28 MiB 572.22 KiB
9246ed4 1.72 MiB 2.28 MiB 572.22 KiB
dc67004 1.72 MiB 2.28 MiB 573.45 KiB
496bdfd 1.72 MiB 2.28 MiB 571.82 KiB
8820c5c 1.72 MiB 2.28 MiB 571.82 KiB
496bdfd 1.72 MiB 2.28 MiB 571.82 KiB
c03a05e 1.72 MiB 2.29 MiB 574.43 KiB
0310da5 1.72 MiB 2.28 MiB 573.45 KiB

Previous results on branch: fix/frame-metrics-collector-concurrent-map

Startup times

Revision Plain With Sentry Diff
7f6a84c 287.26 ms 309.96 ms 22.70 ms

App size

Revision Plain With Sentry Diff
7f6a84c 1.72 MiB 2.29 MiB 575.00 KiB

@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (f274c79) 81.28% compared to head (de43dc3) 81.28%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2823   +/-   ##
=========================================
  Coverage     81.28%   81.28%           
  Complexity     4562     4562           
=========================================
  Files           350      350           
  Lines         16867    16867           
  Branches       2272     2272           
=========================================
  Hits          13710    13710           
  Misses         2216     2216           
  Partials        941      941           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@stefanosiano stefanosiano marked this pull request as ready for review July 6, 2023 10:19
Copy link
Member

@markushi markushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Nice!

@stefanosiano stefanosiano merged commit 5fe0117 into main Jul 10, 2023
@stefanosiano stefanosiano deleted the fix/frame-metrics-collector-concurrent-map branch July 10, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ConcurrentModificationException in SentryFrameMetricsCollector
2 participants