-
-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix concurrent access to frameMetrics listener #2823
Merged
stefanosiano
merged 3 commits into
main
from
fix/frame-metrics-collector-concurrent-map
Jul 10, 2023
Merged
Fix concurrent access to frameMetrics listener #2823
stefanosiano
merged 3 commits into
main
from
fix/frame-metrics-collector-concurrent-map
Jul 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
f274c79 | 313.96 ms | 355.96 ms | 42.00 ms |
9246ed4 | 281.79 ms | 352.08 ms | 70.29 ms |
9246ed4 | 275.63 ms | 321.31 ms | 45.69 ms |
dc67004 | 273.86 ms | 346.37 ms | 72.51 ms |
496bdfd | 301.22 ms | 343.96 ms | 42.73 ms |
8820c5c | 330.60 ms | 416.86 ms | 86.26 ms |
496bdfd | 272.86 ms | 407.33 ms | 134.48 ms |
c03a05e | 390.40 ms | 419.35 ms | 28.94 ms |
0310da5 | 381.20 ms | 404.50 ms | 23.30 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
f274c79 | 1.72 MiB | 2.29 MiB | 575.01 KiB |
9246ed4 | 1.72 MiB | 2.28 MiB | 572.22 KiB |
9246ed4 | 1.72 MiB | 2.28 MiB | 572.22 KiB |
dc67004 | 1.72 MiB | 2.28 MiB | 573.45 KiB |
496bdfd | 1.72 MiB | 2.28 MiB | 571.82 KiB |
8820c5c | 1.72 MiB | 2.28 MiB | 571.82 KiB |
496bdfd | 1.72 MiB | 2.28 MiB | 571.82 KiB |
c03a05e | 1.72 MiB | 2.29 MiB | 574.43 KiB |
0310da5 | 1.72 MiB | 2.28 MiB | 573.45 KiB |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #2823 +/- ##
=========================================
Coverage 81.28% 81.28%
Complexity 4562 4562
=========================================
Files 350 350
Lines 16867 16867
Branches 2272 2272
=========================================
Hits 13710 13710
Misses 2216 2216
Partials 941 941 ☔ View full report in Codecov by Sentry. |
markushi
requested changes
Jul 7, 2023
...oid-core/src/main/java/io/sentry/android/core/internal/util/SentryFrameMetricsCollector.java
Show resolved
Hide resolved
markushi
approved these changes
Jul 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Nice!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
changed metrics listener map from HashMap to ConcurrentHashMap
💡 Motivation and Context
Fixes #2816
💚 How did you test it?
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps