-
-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align http.status to span data convention #2786
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…data convention added `http.response.status_code` to http request spans
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
8820c5c | 330.60 ms | 416.86 ms | 86.26 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
8820c5c | 1.72 MiB | 2.28 MiB | 571.82 KiB |
Previous results on branch: fix/align_http_status_convention
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
2ee8c50 | 322.08 ms | 345.68 ms | 23.60 ms |
d57a7af | 260.27 ms | 332.88 ms | 72.61 ms |
bb0ce2f | 285.75 ms | 382.22 ms | 96.47 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
2ee8c50 | 1.72 MiB | 2.28 MiB | 571.72 KiB |
d57a7af | 1.72 MiB | 2.28 MiB | 571.82 KiB |
bb0ce2f | 1.72 MiB | 2.28 MiB | 571.72 KiB |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2786 +/- ##
=========================================
Coverage 81.13% 81.14%
- Complexity 4493 4497 +4
=========================================
Files 348 348
Lines 16659 16677 +18
Branches 2263 2267 +4
=========================================
+ Hits 13517 13532 +15
- Misses 2197 2198 +1
- Partials 945 947 +2
☔ View full report in Codecov by Sentry. |
romtsn
approved these changes
Jun 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
added DataConvention interface to hold all strings aligned with span data convention
added
http.response.status_code
to http request spans💡 Motivation and Context
The http status should be set in the same place by all the SDKs
Relates to getsentry/team-mobile#121
💚 How did you test it?
Unit tests
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps