Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align http.status to span data convention #2786

Merged
merged 5 commits into from
Jun 16, 2023

Conversation

stefanosiano
Copy link
Member

📜 Description

added DataConvention interface to hold all strings aligned with span data convention
added http.response.status_code to http request spans

💡 Motivation and Context

The http status should be set in the same place by all the SDKs
Relates to getsentry/team-mobile#121

💚 How did you test it?

Unit tests

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@stefanosiano stefanosiano marked this pull request as ready for review June 13, 2023 16:04
@github-actions
Copy link
Contributor

github-actions bot commented Jun 13, 2023

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 288.70 ms 343.44 ms 54.74 ms
Size 1.72 MiB 2.28 MiB 571.82 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
8820c5c 330.60 ms 416.86 ms 86.26 ms

App size

Revision Plain With Sentry Diff
8820c5c 1.72 MiB 2.28 MiB 571.82 KiB

Previous results on branch: fix/align_http_status_convention

Startup times

Revision Plain With Sentry Diff
2ee8c50 322.08 ms 345.68 ms 23.60 ms
d57a7af 260.27 ms 332.88 ms 72.61 ms
bb0ce2f 285.75 ms 382.22 ms 96.47 ms

App size

Revision Plain With Sentry Diff
2ee8c50 1.72 MiB 2.28 MiB 571.72 KiB
d57a7af 1.72 MiB 2.28 MiB 571.82 KiB
bb0ce2f 1.72 MiB 2.28 MiB 571.72 KiB

@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Patch coverage: 78.26% and no project coverage change.

Comparison is base (3bb708a) 81.13% compared to head (43f4e4c) 81.14%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2786   +/-   ##
=========================================
  Coverage     81.13%   81.14%           
- Complexity     4493     4497    +4     
=========================================
  Files           348      348           
  Lines         16659    16677   +18     
  Branches       2263     2267    +4     
=========================================
+ Hits          13517    13532   +15     
- Misses         2197     2198    +1     
- Partials        945      947    +2     
Impacted Files Coverage Δ
...racing/SentrySpanClientHttpRequestInterceptor.java 0.00% <0.00%> (ø)
...racing/SentrySpanClientHttpRequestInterceptor.java 0.00% <0.00%> (ø)
.../io/sentry/apollo3/SentryApollo3HttpInterceptor.kt 84.38% <75.00%> (+0.55%) ⬆️
...n/java/io/sentry/apollo/SentryApolloInterceptor.kt 81.31% <77.77%> (-1.04%) ⬇️
...in/java/io/sentry/openfeign/SentryFeignClient.java 94.44% <100.00%> (+0.07%) ⬆️
...arta/tracing/SentrySpanClientWebRequestFilter.java 72.34% <100.00%> (+0.60%) ⬆️
...ring/tracing/SentrySpanClientWebRequestFilter.java 73.46% <100.00%> (+0.55%) ⬆️
...sentry/instrumentation/file/FileIOSpanManager.java 90.00% <100.00%> (+0.20%) ⬆️
sentry/src/main/java/io/sentry/util/UrlUtils.java 91.13% <100.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@romtsn romtsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CHANGELOG.md Outdated Show resolved Hide resolved
sentry/src/main/java/io/sentry/DataConvention.java Outdated Show resolved Hide resolved
@stefanosiano stefanosiano merged commit 496bdfd into main Jun 16, 2023
@stefanosiano stefanosiano deleted the fix/align_http_status_convention branch June 16, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants