-
-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load sentry-debug-meta.properties #2734
Load sentry-debug-meta.properties #2734
Conversation
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
16cd2b6 | 243.02 ms | 349.69 ms | 106.67 ms |
46b1782 | 387.72 ms | 458.74 ms | 71.02 ms |
1707044 | 338.80 ms | 384.79 ms | 46.00 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
16cd2b6 | 1.72 MiB | 2.28 MiB | 570.95 KiB |
46b1782 | 1.72 MiB | 2.28 MiB | 570.44 KiB |
1707044 | 1.72 MiB | 2.28 MiB | 570.44 KiB |
Previous results on branch: feat/load-debug-meta-properties-for-non-android
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
042f7ad | 331.06 ms | 350.62 ms | 19.56 ms |
e284a1e | 295.77 ms | 319.94 ms | 24.17 ms |
8c386e8 | 367.82 ms | 382.14 ms | 14.32 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
042f7ad | 1.72 MiB | 2.28 MiB | 571.39 KiB |
e284a1e | 1.72 MiB | 2.28 MiB | 571.09 KiB |
8c386e8 | 1.72 MiB | 2.28 MiB | 571.09 KiB |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2734 +/- ##
============================================
- Coverage 81.10% 81.09% -0.01%
- Complexity 4455 4470 +15
============================================
Files 344 347 +3
Lines 16420 16472 +52
Branches 2227 2232 +5
============================================
+ Hits 13317 13358 +41
- Misses 2174 2181 +7
- Partials 929 933 +4
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one, looking good! On Android it could make sense to lazy read the properties file, but since it wasn't done before either this could be a covered in future improvement ticket.
📜 Description
We now also load
sentry-debug-meta.properties
for Java (not just Android). This means source bundle IDs are now loaded at runtime and sent to Sentry to enable source context.💡 Motivation and Context
Source Context for Java (non Android)
💚 How did you test it?
Unit Tests, manually
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps