-
-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Encode/Decode internal apollo3 headers #2707
Conversation
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
d9bd3b7 | 314.76 ms | 355.60 ms | 40.84 ms |
3ecfb25 | 301.62 ms | 368.38 ms | 66.76 ms |
bccb1ad | 314.51 ms | 380.98 ms | 66.47 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
d9bd3b7 | 1.72 MiB | 2.28 MiB | 565.45 KiB |
3ecfb25 | 1.72 MiB | 2.28 MiB | 570.00 KiB |
bccb1ad | 1.72 MiB | 2.28 MiB | 570.00 KiB |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2707 +/- ##
============================================
- Coverage 81.11% 81.11% -0.01%
- Complexity 4445 4447 +2
============================================
Files 345 345
Lines 16387 16394 +7
Branches 2226 2226
============================================
+ Hits 13293 13298 +5
- Misses 2166 2168 +2
Partials 928 928
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM. I think we should should handle decode exceptions directly in code, not sure Apollo fails the request if we throw out.
sentry-apollo-3/src/main/java/io/sentry/apollo3/SentryApollo3HttpInterceptor.kt
Outdated
Show resolved
Hide resolved
sentry-apollo-3/src/main/java/io/sentry/apollo3/SentryApollo3HttpInterceptor.kt
Outdated
Show resolved
Hide resolved
sentry-apollo-3/src/main/java/io/sentry/apollo3/SentryApollo3HttpInterceptor.kt
Outdated
Show resolved
Hide resolved
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
📜 Description
Base64 encode/decode internal apollo3 headers
💡 Motivation and Context
Fixes #2680
💚 How did you test it?
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps