-
-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Track a ttfd span per Activity #2673
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ally stop only the correct one
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
33c80c7 | 331.94 ms | 370.54 ms | 38.60 ms |
d81684e | 235.73 ms | 328.76 ms | 93.03 ms |
17ab223 | 427.65 ms | 484.31 ms | 56.65 ms |
33c80c7 | 318.88 ms | 348.14 ms | 29.26 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
33c80c7 | 1.73 MiB | 2.26 MiB | 551.46 KiB |
d81684e | 1.73 MiB | 2.26 MiB | 547.78 KiB |
17ab223 | 1.73 MiB | 2.34 MiB | 626.85 KiB |
33c80c7 | 1.73 MiB | 2.26 MiB | 551.46 KiB |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #2673 +/- ##
=========================================
Coverage 81.28% 81.28%
Complexity 4263 4263
=========================================
Files 337 337
Lines 15759 15759
Branches 2080 2080
=========================================
Hits 12810 12810
Misses 2128 2128
Partials 821 821 ☔ View full report in Codecov by Sentry. |
stefanosiano
requested review from
adinauer,
romtsn and
markushi
as code owners
April 24, 2023 12:59
markushi
approved these changes
Apr 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Added map of ttfd spans in ActivityLifecycleIntegration, to automatically stop only the correct one.
💡 Motivation and Context
Due to Activity lifecycle, during a navigation between two activities, when the previous activity was destroyed the
ActivityLifecycleIntegration
was terminating the ttfd span of the new activity.💚 How did you test it?
Unit test
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps