-
-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send source bundle IDs to Sentry to enable source context #2663
Conversation
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
18fd44c | 319.56 ms | 346.52 ms | 26.96 ms |
a874a2b | 266.36 ms | 300.96 ms | 34.60 ms |
e4bf816 | 324.88 ms | 373.04 ms | 48.16 ms |
a86d5e0 | 280.14 ms | 347.66 ms | 67.52 ms |
2353697 | 340.45 ms | 369.04 ms | 28.59 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
18fd44c | 1.72 MiB | 2.28 MiB | 565.87 KiB |
a874a2b | 1.73 MiB | 2.26 MiB | 550.81 KiB |
e4bf816 | 1.73 MiB | 2.26 MiB | 550.84 KiB |
a86d5e0 | 1.72 MiB | 2.28 MiB | 565.87 KiB |
2353697 | 1.72 MiB | 2.28 MiB | 565.88 KiB |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2663 +/- ##
============================================
+ Coverage 81.07% 81.11% +0.03%
- Complexity 4432 4445 +13
============================================
Files 345 345
Lines 16358 16387 +29
Branches 2219 2226 +7
============================================
+ Hits 13263 13293 +30
+ Misses 2167 2166 -1
Partials 928 928
☔ View full report in Codecov by Sentry. |
First pass looks good 👍 not sure if this will change much anyway |
sentry-android-core/src/main/java/io/sentry/android/core/AndroidOptionsInitializer.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Roman Zavarnitsyn <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 great stuff
📜 Description
Sends source bundle ID(s) to Sentry as part of
debug_meta
of errors and transactions.💡 Motivation and Context
Required to send bundle IDs to sentry with events so backend processing can look up sources that were uploaded at build/release time. See #633 for more details.
💚 How did you test it?
Manually + unit tests
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps