Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send source bundle IDs to Sentry to enable source context #2663

Merged
merged 11 commits into from
May 15, 2023

Conversation

adinauer
Copy link
Member

@adinauer adinauer commented Apr 19, 2023

📜 Description

Sends source bundle ID(s) to Sentry as part of debug_meta of errors and transactions.

💡 Motivation and Context

Required to send bundle IDs to sentry with events so backend processing can look up sources that were uploaded at build/release time. See #633 for more details.

💚 How did you test it?

Manually + unit tests

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@adinauer adinauer self-assigned this Apr 19, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 19, 2023

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 84a5206

@adinauer adinauer mentioned this pull request Apr 19, 2023
@adinauer
Copy link
Member Author

@github-actions
Copy link
Contributor

github-actions bot commented Apr 19, 2023

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 335.94 ms 402.42 ms 66.48 ms
Size 1.72 MiB 2.28 MiB 565.88 KiB

Previous results on branch: feat/pickup-bundle-id-and-send-with-event

Startup times

Revision Plain With Sentry Diff
18fd44c 319.56 ms 346.52 ms 26.96 ms
a874a2b 266.36 ms 300.96 ms 34.60 ms
e4bf816 324.88 ms 373.04 ms 48.16 ms
a86d5e0 280.14 ms 347.66 ms 67.52 ms
2353697 340.45 ms 369.04 ms 28.59 ms

App size

Revision Plain With Sentry Diff
18fd44c 1.72 MiB 2.28 MiB 565.87 KiB
a874a2b 1.73 MiB 2.26 MiB 550.81 KiB
e4bf816 1.73 MiB 2.26 MiB 550.84 KiB
a86d5e0 1.72 MiB 2.28 MiB 565.87 KiB
2353697 1.72 MiB 2.28 MiB 565.88 KiB

@codecov
Copy link

codecov bot commented Apr 19, 2023

Codecov Report

Patch coverage: 93.75% and project coverage change: +0.03 🎉

Comparison is base (5a573d4) 81.07% compared to head (84a5206) 81.11%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2663      +/-   ##
============================================
+ Coverage     81.07%   81.11%   +0.03%     
- Complexity     4432     4445      +13     
============================================
  Files           345      345              
  Lines         16358    16387      +29     
  Branches       2219     2226       +7     
============================================
+ Hits          13263    13293      +30     
+ Misses         2167     2166       -1     
  Partials        928      928              
Impacted Files Coverage Δ
...y/src/main/java/io/sentry/protocol/DebugImage.java 89.13% <ø> (+1.08%) ⬆️
sentry/src/main/java/io/sentry/SentryOptions.java 80.58% <80.00%> (-0.02%) ⬇️
...entry/src/main/java/io/sentry/ExternalOptions.java 98.00% <100.00%> (+0.09%) ⬆️
...ry/src/main/java/io/sentry/MainEventProcessor.java 87.33% <100.00%> (+2.01%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@romtsn
Copy link
Member

romtsn commented Apr 21, 2023

First pass looks good 👍 not sure if this will change much anyway

@adinauer adinauer marked this pull request as ready for review May 11, 2023 10:53
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Roman Zavarnitsyn <[email protected]>
Copy link
Member

@romtsn romtsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 great stuff

@adinauer adinauer merged commit 70ef023 into main May 15, 2023
@adinauer adinauer deleted the feat/pickup-bundle-id-and-send-with-event branch May 15, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants