-
-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix timestamp intervals of PerformanceCollectionData in profiles #2648
Conversation
updated ui test to cover all measurements cases
updated ui test to cover all measurements cases
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
33c80c7 | 318.88 ms | 348.14 ms | 29.26 ms |
17ab223 | 427.65 ms | 484.31 ms | 56.65 ms |
d81684e | 235.73 ms | 328.76 ms | 93.03 ms |
33c80c7 | 331.94 ms | 370.54 ms | 38.60 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
33c80c7 | 1.73 MiB | 2.26 MiB | 551.46 KiB |
17ab223 | 1.73 MiB | 2.34 MiB | 626.85 KiB |
d81684e | 1.73 MiB | 2.26 MiB | 547.78 KiB |
33c80c7 | 1.73 MiB | 2.26 MiB | 551.46 KiB |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #2648 +/- ##
=========================================
Coverage 81.39% 81.39%
Complexity 4227 4227
=========================================
Files 337 337
Lines 15622 15622
Branches 2039 2039
=========================================
Hits 12715 12715
Misses 2112 2112
Partials 795 795 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
updated ui test to cover all measurements cases
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RSLGTM
📜 Description
fixed timestamps of PerformanceCollectionData in profiles
updated ui test to cover all measurements cases
💡 Motivation and Context
The PerformanceCollectionData measurements in the profiles were not converted to nanoseconds, generating problems with their intervals
💚 How did you test it?
Updated ui test
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps