-
-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sent_at
to envelope header item
#2638
Conversation
# Conflicts: # sentry/src/test/java/io/sentry/SentryClientTest.kt
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
33c80c7 | 318.88 ms | 348.14 ms | 29.26 ms |
17ab223 | 427.65 ms | 484.31 ms | 56.65 ms |
d81684e | 235.73 ms | 328.76 ms | 93.03 ms |
33c80c7 | 331.94 ms | 370.54 ms | 38.60 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
33c80c7 | 1.73 MiB | 2.26 MiB | 551.46 KiB |
17ab223 | 1.73 MiB | 2.34 MiB | 626.85 KiB |
d81684e | 1.73 MiB | 2.26 MiB | 547.78 KiB |
33c80c7 | 1.73 MiB | 2.26 MiB | 551.46 KiB |
Previous results on branch: enha/envelope_header_sent_at
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
5367e69 | 320.04 ms | 363.33 ms | 43.29 ms |
7280518 | 283.38 ms | 348.82 ms | 65.44 ms |
d8bf1ac | 324.34 ms | 364.22 ms | 39.88 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
5367e69 | 1.73 MiB | 2.27 MiB | 551.83 KiB |
7280518 | 1.73 MiB | 2.27 MiB | 551.83 KiB |
d8bf1ac | 1.73 MiB | 2.26 MiB | 550.51 KiB |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2638 +/- ##
============================================
+ Coverage 81.25% 81.42% +0.17%
+ Complexity 4259 4231 -28
============================================
Files 337 337
Lines 15741 15640 -101
Branches 2079 2040 -39
============================================
- Hits 12790 12735 -55
+ Misses 2130 2110 -20
+ Partials 821 795 -26
... and 5 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! I left a few comments for some minor improvements
# Conflicts: # CHANGELOG.md
Changed the implementation due to the discussion on the cocoa PR |
thanks @denrase 👍 |
📜 Description
sent_at
property to envelope header💡 Motivation and Context
Relates to getsentry/sentry-dart#1337
Doc: https://develop.sentry.dev/sdk/envelopes/
💚 How did you test it?
Unit tests
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps
Add to cocoa sdk