-
-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trim time-to-full-display span if reportFullyDisplayed API is never called #2631
Conversation
exposed `getFinishDate` internally in ISpan
Performance metrics 🚀
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2631 +/- ##
=========================================
Coverage 81.37% 81.37%
- Complexity 4219 4221 +2
=========================================
Files 337 337
Lines 15599 15601 +2
Branches 2037 2037
=========================================
+ Hits 12693 12695 +2
Misses 2111 2111
Partials 795 795
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
sentry-android-core/src/main/java/io/sentry/android/core/ActivityLifecycleIntegration.java
Outdated
Show resolved
Hide resolved
sentry-android-core/src/main/java/io/sentry/android/core/ActivityLifecycleIntegration.java
Show resolved
Hide resolved
aligned with cocoa for " - Deadline Exceeded" suffix
aligned with cocoa for " - Deadline Exceeded" suffix
📜 Description
ttfd span is trimmed if
reportFullyDisplayed
API is never calledexposed
getFinishDate
internally in ISpan💡 Motivation and Context
Currently if the user enables the option to track the fullDisplay, the transaction keeps running and if the manual API is never called, the
time-to-full-display
span would always last 30 seconds, increasing the transaction duration.This change aims to mitigate this issue, so that if no other spans are present, the total transaction duration would be until the
time-to-initial-display
span is finished.💚 How did you test it?
Unit test
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps