-
-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Automatic UI transactions having wrong durations #2623
Conversation
…not appStart span is present Span now trims for all transaction children if it's the root span of the transaction
Performance metrics 🚀
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2623 +/- ##
============================================
+ Coverage 81.31% 81.32% +0.01%
- Complexity 4187 4192 +5
============================================
Files 336 336
Lines 15485 15489 +4
Branches 2020 2021 +1
============================================
+ Hits 12591 12597 +6
+ Misses 2101 2099 -2
Partials 793 793
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@@ -193,7 +193,12 @@ public void finish(final @Nullable SpanStatus status, final @Nullable SentryDate | |||
@Nullable SentryDate minChildStart = null; | |||
@Nullable SentryDate maxChildEnd = null; | |||
|
|||
final @NotNull List<Span> children = getChildren(); | |||
// The root span should be trimmed based on all children, but the other spans, like the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
love this, explains the "why" really good and will make it easier to re-iterate over this in future.
📜 Description
Automatic Activity transactions now have the ttid start timestamp if appStart span is not present
Span now trims for all transaction children if it's the root span of the transaction
💡 Motivation and Context
The reported duration of the transaction is wrong.
💚 How did you test it?
Added Unit tests
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps