Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass through unknown sentry baggage keys into SentryEnvelopeHeader #2618

Merged
merged 4 commits into from
Mar 28, 2023

Conversation

adinauer
Copy link
Member

📜 Description

When converting Baggage to TraceContext also keep unknown keys prefixed with sentry- and send them to Sentry via SentryEnvelopeHeader.

💡 Motivation and Context

So we don't have to add every new key explicitly and instead simply pass through all unknown keys.

💚 How did you test it?

Unit Tests, manually using Sample

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Mar 22, 2023

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 182cda4

@github-actions
Copy link
Contributor

github-actions bot commented Mar 22, 2023

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 352.35 ms 381.98 ms 29.63 ms
Size 1.73 MiB 2.34 MiB 626.85 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
d81684e 235.73 ms 328.76 ms 93.03 ms

App size

Revision Plain With Sentry Diff
d81684e 1.73 MiB 2.26 MiB 547.78 KiB

Previous results on branch: feat/pass-through-unknown-sentry-baggage-keys

Startup times

Revision Plain With Sentry Diff
efc6b6a 337.48 ms 342.04 ms 4.56 ms

App size

Revision Plain With Sentry Diff
efc6b6a 1.73 MiB 2.26 MiB 547.95 KiB

@codecov
Copy link

codecov bot commented Mar 22, 2023

Codecov Report

Patch coverage: 86.02% and project coverage change: +0.01 🎉

Comparison is base (70c2097) 81.32% compared to head (182cda4) 81.34%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2618      +/-   ##
============================================
+ Coverage     81.32%   81.34%   +0.01%     
- Complexity     4192     4211      +19     
============================================
  Files           336      337       +1     
  Lines         15489    15575      +86     
  Branches       2021     2034      +13     
============================================
+ Hits          12597    12670      +73     
- Misses         2099     2110      +11     
- Partials        793      795       +2     
Impacted Files Coverage Δ
sentry/src/main/java/io/sentry/protocol/Geo.java 81.48% <81.48%> (ø)
sentry/src/main/java/io/sentry/protocol/User.java 89.52% <88.23%> (-0.25%) ⬇️
sentry/src/main/java/io/sentry/Baggage.java 86.39% <95.23%> (+0.58%) ⬆️
sentry/src/main/java/io/sentry/JsonSerializer.java 98.03% <100.00%> (+0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@adinauer adinauer merged commit 2ec7569 into main Mar 28, 2023
@adinauer adinauer deleted the feat/pass-through-unknown-sentry-baggage-keys branch March 28, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants