Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep integration names from being obfuscated #2599

Merged
merged 3 commits into from
Mar 13, 2023

Conversation

lbloder
Copy link
Collaborator

@lbloder lbloder commented Mar 12, 2023

📜 Description

Add proguard rules to keep Classnames for integrations

💡 Motivation and Context

Fixes #2592

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Mar 12, 2023

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against a06d7b3

@github-actions
Copy link
Contributor

github-actions bot commented Mar 12, 2023

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 412.24 ms 467.02 ms 54.78 ms
Size 1.73 MiB 2.34 MiB 626.68 KiB

Previous results on branch: feat/unobfuscated_integration_names

Startup times

Revision Plain With Sentry Diff
dbbc2fc 351.24 ms 354.86 ms 3.61 ms

App size

Revision Plain With Sentry Diff
dbbc2fc 1.73 MiB 2.34 MiB 626.68 KiB

@codecov
Copy link

codecov bot commented Mar 12, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02 🎉

Comparison is base (3a20d40) 81.14% compared to head (a06d7b3) 81.17%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2599      +/-   ##
============================================
+ Coverage     81.14%   81.17%   +0.02%     
- Complexity     4096     4102       +6     
============================================
  Files           333      333              
  Lines         15193    15213      +20     
  Branches       1980     1980              
============================================
+ Hits          12329    12349      +20     
  Misses         2084     2084              
  Partials        780      780              
Impacted Files Coverage Δ
.../spring/boot/jakarta/SentryLogbackInitializer.java 96.87% <100.00%> (+0.72%) ⬆️
...o/sentry/spring/boot/jakarta/SentryProperties.java 80.00% <100.00%> (+2.22%) ⬆️
...o/sentry/spring/boot/SentryLogbackInitializer.java 96.87% <100.00%> (+0.72%) ⬆️
...n/java/io/sentry/spring/boot/SentryProperties.java 77.41% <100.00%> (+3.34%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lbloder lbloder marked this pull request as ready for review March 13, 2023 21:46
@lbloder lbloder merged commit 25e36a7 into main Mar 13, 2023
@lbloder lbloder deleted the feat/unobfuscated_integration_names branch March 13, 2023 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keep Integrations class names
3 participants