Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version to sentryClientName used in auth header #2596

Merged
merged 2 commits into from
Mar 10, 2023

Conversation

adinauer
Copy link
Member

@adinauer adinauer commented Mar 9, 2023

📜 Description

Add missing version number to setSentryClientName() invocations.

💡 Motivation and Context

Fixes #2528

💚 How did you test it?

unit tests; debugger

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2023

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 375.10 ms 453.10 ms 78.00 ms
Size 1.73 MiB 2.34 MiB 626.25 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
7c33bc1 413.94 ms 432.41 ms 18.47 ms
7c199d8 323.18 ms 391.33 ms 68.15 ms

App size

Revision Plain With Sentry Diff
7c33bc1 1.73 MiB 2.34 MiB 626.25 KiB
7c199d8 1.73 MiB 2.34 MiB 626.23 KiB

@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Patch coverage: 75.34% and project coverage change: +0.04 🎉

Comparison is base (4eb4794) 80.42% compared to head (5a48309) 80.47%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2596      +/-   ##
============================================
+ Coverage     80.42%   80.47%   +0.04%     
- Complexity     4027     4032       +5     
============================================
  Files           333      333              
  Lines         15189    15205      +16     
  Branches       1979     1982       +3     
============================================
+ Hits          12216    12236      +20     
+ Misses         2194     2189       -5     
- Partials        779      780       +1     
Impacted Files Coverage Δ
...o/sentry/spring/boot/jakarta/SentryProperties.java 77.77% <ø> (ø)
...g/boot/jakarta/SentryWebfluxAutoConfiguration.java 85.71% <ø> (ø)
...y/spring/jakarta/CachedBodyHttpServletRequest.java 80.00% <ø> (ø)
...y/spring/jakarta/CachedBodyServletInputStream.java 40.00% <ø> (ø)
...sentry/spring/jakarta/RequestPayloadExtractor.java 37.50% <ø> (ø)
...sentry/spring/jakarta/SentryExceptionResolver.java 100.00% <ø> (ø)
...a/io/sentry/spring/jakarta/SentrySpringFilter.java 73.68% <ø> (ø)
...karta/SentrySpringServletContainerInitializer.java 0.00% <ø> (ø)
...ava/io/sentry/spring/jakarta/SentryUserFilter.java 93.33% <ø> (ø)
...racing/SentrySpanClientHttpRequestInterceptor.java 0.00% <0.00%> (ø)
... and 25 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@adinauer adinauer merged commit dd03aa1 into main Mar 10, 2023
@adinauer adinauer deleted the fix/add-version-to-client-name branch March 10, 2023 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

options.setSentryClientName should contain the SDK version as well
2 participants