Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to compileOnly dependencies in sentry-compose #2578

Merged
merged 5 commits into from
Mar 2, 2023

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented Mar 1, 2023

📜 Description

Since our Gradle Plugin is modifying the .pom of the dependencies to auto-install integrations, sentry-compose itself was depending on androidx.compose:runtime, therefore after auto-installing it was creating a circular dependency. This PR fixes that, so the users will have to have compose/compose-navigation on their classpath for our integration to kick in.

It's also fine if they don't have them on the classpath, because our Navigation instrumentation will not be called/installed if there's no NavHostController on the classpath.

Similar to #2175

💡 Motivation and Context

Closes #2364

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

2 more PRs:

@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2023

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 398.67 ms 484.35 ms 85.67 ms
Size 1.73 MiB 2.34 MiB 626.22 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
db5bd4e 352.90 ms 359.52 ms 6.62 ms
d691d8f 352.56 ms 389.59 ms 37.03 ms
db5bd4e 314.82 ms 349.17 ms 34.35 ms
db5bd4e 347.00 ms 366.74 ms 19.74 ms
db5bd4e 286.94 ms 315.26 ms 28.32 ms
e5bbb00 317.46 ms 353.26 ms 35.80 ms

App size

Revision Plain With Sentry Diff
db5bd4e 1.73 MiB 2.34 MiB 626.30 KiB
d691d8f 1.73 MiB 2.34 MiB 626.23 KiB
db5bd4e 1.73 MiB 2.34 MiB 626.30 KiB
db5bd4e 1.73 MiB 2.34 MiB 626.30 KiB
db5bd4e 1.73 MiB 2.34 MiB 626.30 KiB
e5bbb00 1.73 MiB 2.34 MiB 626.22 KiB

Previous results on branch: fix/rz/compose-compile-only

Startup times

Revision Plain With Sentry Diff
6fe76b2 318.16 ms 360.15 ms 41.99 ms
9a990f4 282.16 ms 358.44 ms 76.27 ms

App size

Revision Plain With Sentry Diff
6fe76b2 1.73 MiB 2.34 MiB 626.22 KiB
9a990f4 1.73 MiB 2.34 MiB 626.22 KiB

@codecov
Copy link

codecov bot commented Mar 1, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (e5bbb00) 80.44% compared to head (718a900) 80.44%.

❗ Current head 718a900 differs from pull request most recent head 61f7060. Consider uploading reports for the commit 61f7060 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2578   +/-   ##
=========================================
  Coverage     80.44%   80.44%           
  Complexity     4020     4020           
=========================================
  Files           332      332           
  Lines         15160    15160           
  Branches       1979     1979           
=========================================
  Hits          12195    12195           
  Misses         2186     2186           
  Partials        779      779           
Impacted Files Coverage Δ
sentry/src/main/java/io/sentry/SentryOptions.java 80.43% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@romtsn romtsn enabled auto-merge (squash) March 2, 2023 10:12
@romtsn romtsn merged commit 82f6089 into main Mar 2, 2023
@romtsn romtsn deleted the fix/rz/compose-compile-only branch March 2, 2023 10:13
@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2023

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Switch to compileOnly dependencies in sentry-compose ([#2578](https://github.com/getsentry/sentry-java/pull/2578))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 61f7060

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sentry 6.7.0 causes StackOverflow when linting OSS Licences Plugin
2 participants